Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Drop magrittr dependency? #522

Closed
hadley opened this issue Feb 28, 2021 · 2 comments · Fixed by #532
Closed

Drop magrittr dependency? #522

hadley opened this issue Feb 28, 2021 · 2 comments · Fixed by #532

Comments

@hadley
Copy link
Collaborator

hadley commented Feb 28, 2021

No description provided.

@llrs
Copy link
Collaborator

llrs commented Feb 28, 2021

Yes I think it would be better if the packages focused on Twitter API and preparing data for users. I also considered removing ggplot2 but prepare the data for the ts_plot

@hadley
Copy link
Collaborator Author

hadley commented Feb 28, 2021

Yeah, agreed. That said, a suggested dependency doesn’t increase package weight for most users, so it’s not a big deal to keep it.

hadley pushed a commit that referenced this issue Mar 8, 2021
@llrs @hadley
Drop magrittr
18375af 
Fixes #522
hadley added a commit that referenced this issue Mar 8, 2021
@hadley
Drop magrittr
63a46db 
Fixes #522
@hadley hadley mentioned this issue Mar 8, 2021
Merged
hadley added a commit that referenced this issue Mar 8, 2021
@hadley
Drop magrittr (#532)
dc1a319 
Fixes #522
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop magrittr ropensci-archive/rtweet
2 participants
@hadley @llrs