Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Update roadmap #471

Closed
llrs opened this issue Feb 15, 2021 · 7 comments
Closed

Update roadmap #471

llrs opened this issue Feb 15, 2021 · 7 comments
Assignees

Comments

@llrs
Copy link
Collaborator

llrs commented Feb 15, 2021

Roadmap to update rtweet and clean up issues and PR listed below (on date 2021/02/15):

  • Label/Classify them
  • Close duplicates, or non reproducible if the author do not reply in 1 month.
  • Fix errors/bugs
  • Implement enhancements
  • ? CRAN release? Date:?
Code to return this list of issues/PR (ID, title, comments, last update date) : ```r library("tidyverse") remotes::install_github("llrs/socialGH") socialGH::get_issues("ropensci/rtweet") %>% filter(state != "closed") %>% arrange(id) %>% mutate(fix = " - [ ]") %>% select(fix, id, title, n_comments, updated) %>% knitr::kable() %>% gsub("\\|", ",", .) %>% gsub("^,\\s*", "", .) %>% gsub(",\\s*$", "", .) %>% gsub(",\\s*", ", ", .) %>% gsub("\\s*,", ",", .) %>% gsub("\\], ", "] #", .) %>% # gsub("\\] ([0-9]+)", "] #\\2", .) %>% cat(file = "status.txt", sep = "\n") ```
@llrs
Copy link
Collaborator Author

llrs commented Feb 15, 2021

First batch (ending on issue 317): 33/50 were closed

Number of issues of the list, issue number

50: issue 317
100: issue 388
150: issue 447

@llrs
Copy link
Collaborator Author

llrs commented Feb 16, 2021

Second batch: total 53 closed /100 reviewed from last 50 only 20 issues were closed

At least 3 question about authentication on servers (workaround copy token created in local computer)
Also many questions about location and coordinates.
There were many PR that I didn't close/merge.
Also there seems to be many helper functions that do nothing:

A <- function(x, y, z) {
do.all(A_, list(x = x, y = y, z = z)
}

A_ <- function(x, y, z) {
# Lots of stuff
}

This could be updated to

A <- function(x, y, z) {
# Do stuff
}

This would be slightly faster and wouldn't pollute the namespace so much.

Also it seems that the package assumes that only one token is in use. As an issue mentions support for multiple tokens would be great. This would solve problems with bearer tokens and others.

@llrs
Copy link
Collaborator Author

llrs commented Feb 17, 2021

Update 79/167 so 79/150 reviewed, from the last 50 26 were closed.
This was faster as many are better reported or I was already commenting on the issues.

@llrs
Copy link
Collaborator Author

llrs commented Feb 18, 2021

Finishing reviewing them 85/167 closed, so half of the issues remain.

@llrs
Copy link
Collaborator Author

llrs commented Feb 22, 2021

Following some discussions next release will have breaking changes and thus be major version change?

  1. Tokens: change the default provided by rtweet, and where and how to store them.
  2. Tests: Make test more consistent and easier to work with (probably solving 1 will also help) and using vcr will help prevent changing responses.
  3. Improve internal functions: Stop using as examples internals functions, simplify the process
  4. Provide more functionality: mute/unmute, list those muted, API v2, academic research product...
  5. Remove non-core functionality: ts_plot?

@llrs llrs self-assigned this Feb 22, 2021
@llrs llrs pinned this issue Feb 22, 2021
@llrs
Copy link
Collaborator Author

llrs commented Feb 23, 2021

Note to self, document that multiple images and multiple alt text work, but multiple images and 1 alt_text doesn't. post_tweet("status", media = c("image1.png", "image2.png"), media_alt_text = c("alt_text1")), also test that formally on its own file.

@llrs
Copy link
Collaborator Author

llrs commented Feb 26, 2021

Seems that this is no longer the plan

@llrs llrs closed this as completed Feb 26, 2021
@hadley hadley unpinned this issue Feb 27, 2021
@llrs llrs mentioned this issue Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant