Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Adding the collapse delimiter as parameter #374

Closed
brunj7 opened this issue Nov 20, 2019 · 1 comment
Closed

Adding the collapse delimiter as parameter #374

brunj7 opened this issue Nov 20, 2019 · 1 comment

Comments

@brunj7
Copy link

brunj7 commented Nov 20, 2019

Thanks for this great package! This is a suggestion:

It will be great if the user was able to choose the delimiter as a parameter for 'flatten()and thuswrite_as_csv()`

Let me know if it sounds useful. Happy to do a PR with this small change implemented

@mkearney
Copy link
Collaborator

Would happily accept this as a PR, but I would want to check how it gets implemented in save_as_csv() via flattening/deflattening–i.e., read_as_csv() assumes $mentions_user_id is space delim so ideally it'd be able to detect (obvi ones: space, comma, plus-sign) and allow user spec via delim argument.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants