forked from obytes/react-native-template-obytes
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eas build --local #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandatoledo
force-pushed
the
chore/eas
branch
from
August 7, 2024 17:33
c1312ac
to
582ae9e
Compare
fernandatoledo
requested review from
marcos09,
asdolo,
juanchoperezj and
guillermomachado
August 8, 2024 12:53
guillermomachado
approved these changes
Aug 8, 2024
asdolo
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why did you do this?
Eas build was failing locally, on next PRs I'll be focusing on making sure the build works on the cloud too. When building with eas locally, as the envfiles are git ignored and the eas secrets on the cloud are not accessible there was no way to extract the env variables.
It was with a combination of solutions provided on this issue expo/eas-cli#2392 and expo/eas-cli#2195 that I was able to come up with this solution.
Who/what does this impact?
Eas
How did you test this?
Built eas locally successfully :)
How can you test this?
Download the branch and run
build:staging:android:local
orbuild:staging:ios:local