Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eas build --local #26

Merged
merged 14 commits into from
Aug 19, 2024
Merged

Eas build --local #26

merged 14 commits into from
Aug 19, 2024

Conversation

fernandatoledo
Copy link
Collaborator

@fernandatoledo fernandatoledo commented Aug 6, 2024

What does this do?

  • Update eas values with ones from Rootstrap.
  • Adds a new script to build with eas locally, this script also calls a new script to set the env variables from .env.staging on the terminal, so they can be used by eas build.

Why did you do this?

Eas build was failing locally, on next PRs I'll be focusing on making sure the build works on the cloud too. When building with eas locally, as the envfiles are git ignored and the eas secrets on the cloud are not accessible there was no way to extract the env variables.
It was with a combination of solutions provided on this issue expo/eas-cli#2392 and expo/eas-cli#2195 that I was able to come up with this solution.

Who/what does this impact?

Eas

How did you test this?

Built eas locally successfully :)

How can you test this?

Download the branch and run build:staging:android:local or build:staging:ios:local

Copy link

github-actions bot commented Aug 6, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 42%
41.33% (210/508) 36.72% (83/226) 27.83% (54/194)

😎 Tests Results

Tests Skipped Failures Errors Time
47 0 💤 0 ❌ 0 🔥 27.11s ⏱️
👀 Tests Details • (42%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files41.3336.7227.8342.44 
report-only-changed-files is enabled. No files were changed in this commit :)

@fernandatoledo fernandatoledo marked this pull request as ready for review August 8, 2024 12:53
@fernandatoledo fernandatoledo requested a review from a team as a code owner August 8, 2024 12:53
@fernandatoledo fernandatoledo changed the title Chore/eas Eas build --local Aug 8, 2024
@asdolo asdolo marked this pull request as draft August 12, 2024 14:32
@fernandatoledo fernandatoledo marked this pull request as ready for review August 19, 2024 14:01
@fernandatoledo fernandatoledo merged commit 0a67402 into master Aug 19, 2024
8 checks passed
@fernandatoledo fernandatoledo deleted the chore/eas branch August 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants