Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new release is needed in order to update packagist and support Composer 2.0 #4

Closed
4 tasks done
furins opened this issue Oct 24, 2020 · 9 comments
Closed
4 tasks done

Comments

@furins
Copy link

furins commented Oct 24, 2020

Description

install worpdress-core-installer now fails because Composer 2.0 is out.
Actual version of worpdress-core-installer on packagist.org is 1.1.0 (2018-12-10) so it does not include the recent PR merge #3 (Allow Composer V2).

Steps to reproduce

  1. update composer
  2. composer require roots/wordpress-core-installer

or run a vanilla trellis install (the issue is blocking the provisioning of new VMs).

Expected behavior:
Package wordpress-core-installer should install.

Actual behavior: [What actually happens]

$ composer require roots/wordpress-core-installer


  [InvalidArgumentException]
  Package roots/wordpress-core-installer at version  has a PHP requirement incompatible with your PHP version, PHP extensions and Composer version


require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--no-scripts] [--update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>]...

Reproduces how often:
Always, since 2020-10-24.

@austinpray
Copy link

The master version of this repo actually contains the proper patches. Just need to tag a release. Will do that today at some point.

@furins
Copy link
Author

furins commented Oct 25, 2020

Thank you Austin!

@austinpray
Copy link

@furins I just released 1.100.0 after a small amount of testing. In your development environment can you try composer update roots/wordpress-core-installer performs as you expect under composer 2? Works on my machine:tm:

@SimJoSt
Copy link

SimJoSt commented Oct 28, 2020

Works for me.

@furins
Copy link
Author

furins commented Oct 28, 2020

@austinpray I've checked both in my development environment and with a new trellis install. Everything works smoothly. Thank you!

@furins furins closed this as completed Oct 28, 2020
@vladolaru
Copy link

@austinpray Could we get that release? Thanks

@austinpray
Copy link

@austinpray Could we get that release? Thanks

@vladolaru #4 (comment)

@vladolaru
Copy link

Oh. So it is not version 2.0 but 1.100.0

The things is that in the Readme.md it is "roots/wordpress-core-installer": "^2.0"

@austinpray
Copy link

@vladolaru yeah that's a merge error/oversight when pulling from the upstream. Send a PR to fix and I'll merge it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants