Fix conditional logic for permalink setup task #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Setup Permalink Structure" task currently runs
when: "wp_permalink_check_results.changed
. However,wp_permalink_check_results
will never bechanged
because of thechanged_when
rule:This PR updates the conditional logic.
Same as original: Sets permalink structure only if
site_install: true
and non-multisite.Different from original: Runs only in conjunction with new install. Will never run when WP is already installed (even if permalink structure is not set). The rationale is that if WP is already installed, we don't want to potentially override configs users may have set via other means (WP GUI, via wp-cli). As an example, if a user has flushed their rewrite rules, we don't want to reset the rules.