Fixes Multisite Install #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised Ansible conditionals for install plays Added commented landrush block. Cleanup and rewrite conditional Fix trailing slash issue server_name fix from @austinpray Makes WordPress Install Idempotent
Closed
|
@austinpray This has been awhile, but can I ask what "fix trailing slash issue" addresses? I had added it in #240 and it addresses a redirect loop situation. I haven't had problems but am curious what you ran into. |
|
@Alan-c was the one who made this commit. I just squashed it for him |
|
I'll look at my notes, but as I recall the trailing slash was creating a redirect loop that was interfering with admin access to the primary site (only) for logged-in users with a subdirectory (only) multisite install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised Ansible conditionals for install plays
Added commented landrush block.
Cleanup and rewrite conditional
Fix trailing slash issue
server_name fix from @austinpray
Makes WordPress Install Idempotent
closes #283
closes #266