Exempt from is-installed check the DB error dump PHP warning for not yet set up multisite sites
#1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet set up multisite sites.
strarsis
changed the title
is-installed check the DB error dump PHP warning for not yet set up multisite sites
swalkinshaw
reviewed
Jun 11, 2022
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the recently added
stderrexemption of a specific PHP warning from the WP CLIwp core is-installedcommand for multisite sites to the DB error dump that occurs with not yet set up multisite sites.This eliminates the need for letting the WP CLI require a temporary PHP file with constants that disable the multisite feature, which itself caused fatal PHP errors in recent WordPress/Bedrock/Trellis setups where those multisite constants where redefined in the Bedrock application config.
Initial deployment of multisite sites will successfully complete and allow finalization of the site setup (by using the WP CLI, web GUI setup process, importing a database dump/transfer uploads/data files, etc).
http://<a canonical host or domain_current_site>/wp/wp-admin/install.phpas frontend request redirection to the setup web GUI page may not work until the site setup is completed.Should Ansible clean up an existing(added: https://github.com/roots/trellis/pull/1391/files#diff-da02775cb0a887a7b8c5f5183fffe57a8840d53f47065f919dff77ad2accd4a0R2-R6)tmp_multisite_constants.phpfile? It would be useless anyway and its purpose become forgotten on existing Trellis systems.