Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Fix: [306] Shells that use pipes should set the pipefail option #1153

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

tangrufus
Copy link
Member

@tangrufus tangrufus commented Feb 16, 2020

Tested deploy without subdirectory and rollback.

Need help testing deploy with subdirectory and Lets Encrypt.


Discussion: Is it safe to assume bash lives at /bin/bash?

Alternatively, we can do executable: {{ bash_path }}
See also:

@tangrufus tangrufus changed the title [WIP] Lint: Fix: [306] Shells that use pipes should set the pipefail option Lint: Fix: [306] Shells that use pipes should set the pipefail option Feb 22, 2020
@tangrufus tangrufus marked this pull request as ready for review February 22, 2020 17:13
Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe to assume bash lives at /bin/bash

Should be since we only support Ubuntu

@tangrufus tangrufus merged commit 895de7b into roots:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants