composer install with --classmap-authoritative during deploy
#1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrufus
force-pushed
the
composer-classmap-authoritative
branch
from
d275de4 to
c97af88
Compare
tangrufus
changed the title
composer install with --classmap-authoritative during deploycomposer install with --classmap-authoritative during deploy
swalkinshaw
reviewed
Jan 9, 2020
roles/deploy/defaults/main.yml
Outdated
| @@ -48,6 +48,9 @@ project_current_path: "{{ project.current_path | default('current') }}" | |||
| # Whether to run `wp core update-db` at end of each deploy | |||
| update_db_on_deploy: true | |||
|
|
|||
| # Whether to autoload classes from classmap only. | |||
| composer_classmap_authoritative: false | |||
There was a problem hiding this comment.
Are you thinking that true isn't safe enough as the default?
There was a problem hiding this comment.
Correct.
I am running --classmap-authoritative to see any of my sites break.
Maybe default to true on next major relrease
There was a problem hiding this comment.
After a second thought, it is very difficult to make a wp plugin that:
- generates classes dynamically, and
- relies on bedrock's composer autoloader
Defaults composer_classmap_authoritative to true
Ready for review
tangrufus
force-pushed
the
composer-classmap-authoritative
branch
from
c97af88 to
ec4b295
Compare
tangrufus
changed the title
composer install with --classmap-authoritative during deploycomposer install with --classmap-authoritative during deploy
tangrufus
changed the title
composer install with --classmap-authoritative during deploycomposer install with --classmap-authoritative during deploy
tangrufus
force-pushed
the
composer-classmap-authoritative
branch
from
ec4b295 to
11c51ee
Compare
swalkinshaw
approved these changes
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: