Improve dependency requirements #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
commented
Aug 17, 2019
swalkinshaw
force-pushed
the
trellis-cli-integration
branch
from
73bc860 to
634f4aa
Compare
This will be used for trellis-cli integration
|
@tangrufus does this make sense to you? |
|
Looks good to me Extra: Maybe take this chance to mention |
tangrufus
approved these changes
Aug 31, 2019
|
We don't mention Galaxy at all on purpose right now since Vagrant takes care of it by default. But I do need to update the real docs eventually. |
knowler
added a commit
to roots/trellis-cli
that referenced
this pull request
Sep 4, 2019
From `requirements.yml` to `galaxy.yml` as per Trellis v1.1.0 (specifically roots/trellis#1100).
tangrufus
added a commit
to typisttech/tiller-circleci
that referenced
this pull request
Sep 16, 2019
`requirements.yml` is now `galaxy.yml` as per roots/trellis#1100 Updates references from `requirements.yml` to `galaxy.yml` Co-authored-by: Tang Rufus <[email protected]> Co-authored-by: Kelly Mears <[email protected]>
tangrufus
added a commit
to ItinerisLtd/iroots
that referenced
this pull request
Sep 18, 2019
This was referenced Sep 18, 2019
E-VANCE
added a commit
to E-VANCE/trellis-backup-during-deploy
that referenced
this pull request
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate purpose of this PR to improve integration with https://github.com/roots/trellis-cli but these changes are worthwhile enough on their own in my opinion.
Two important but small changes:
requirements.ymltogalaxy.yml. The "requirements" naming is historically forpipdependencies, and since it can be named anything,galaxy.ymlmakes the most sense since it's only for ansible-galaxy and galaxy packages.requirements.txt. It was pretty silly that we never had this anyway. Trellis has dependencies on Ansible (andpasslibon macOS) which we only ever talked about in the README and docs. This just codifies them in arequirements.txtwhich people can use withpip(andvirtualenv) if they use it. If they don't, nothing changes anyway.These changes will also make it possible to trellis-cli to automatically install dependencies.