Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller examples #1910

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Controller examples #1910

merged 1 commit into from
Jun 23, 2017

Conversation

darrenjacoby
Copy link

No description provided.

@retlehs
Copy link
Member

retlehs commented Jun 22, 2017

any thoughts on adding a little bit more? eg. the examples in controller's README

@darrenjacoby
Copy link
Author

Most of the Controller examples in the README rely on Advanced Custom Fields. I've followed the JS files with the above, but not sure it's the best use of Controller.

I feel an App.php and Singular.php (or Single.php and Page.php) might be more obvious that it uses the default WordPress template hierarchy. A good example for Single.php could be getting an array of categories the post belongs to as one can expect that with a default WordPress post.

Let me know what you think?

@retlehs
Copy link
Member

retlehs commented Jun 23, 2017

gonna merge for now, we can always re-iterate 👍

@retlehs retlehs merged commit aced09f into roots:add-controller Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants