Beta 2

[retlehs]

this should partially fix #1804. known issue:

initial browsersync session is still broken and will return the following message:

Uncaught TypeError: __WEBPACK_IMPORTED_MODULE_2__util_Router__[false] is not a constructor
    at Object.<anonymous> (main.js:23)
    at Object.<anonymous> (main.js:27)
    at __webpack_require__ (bootstrap f2d9dd8…:659)
    at fn (bootstrap f2d9dd8…:83)
    at Object.<anonymous> (tether.js:1811)
    at __webpack_require__ (bootstrap f2d9dd8…:659)
    at bootstrap f2d9dd8…:708
    at bootstrap f2d9dd8…:708

error goes away and browsersync should work as expected if you follow these steps:

1. save a file (make a styling change)
2. manually refresh your browsersync session

testing would be appreciated /cc @emilsgulbis @dappa @MWDelaney @psorensen

edit: this branch has since been updated with other commits, the relevant fix for #1804 is 417ce46

edit 2: #1804 is fixed after #1815

[MWDelaney]

This fixes the issue for me!

[psorensen]

Fix works for me as described by @retlehs.

[retlehs]

thank you for testing!

[retlehs]

@eshimischi thanks for pointing that out. updated

[tobeycodes]

What are your thoughts on being able to always filter the data regardless of the body class? E.g. injecting theme options like social media links

[QWp6t]

@schrapel use something like...

sage('blade')->share('links', [
  'facebook' => 'https://facebook.com/myAwesomePage',
  'twitter' => 'https://twitter.com/rootswp',
  // etc..
]); 

Then in all views, a $links variable will be available.

[ghost]

Hi,
I was able to fix the issue mentioned at the beginning of this thread and it is really weird.

1. Downloaded beta-2 (1826102)
2. cd ~/****/wp-content/themes/name/
3. php ../composer.phar install (my composer file is in themes/)
4. yarn upgrade [email protected] to fix the webpack beta 1.9 alert in yarn
5. edit config.json with devURL = localhost:8888 and publicPath = /wp-content/themes/name
6. yarn build
7. yarn run start
   At this point the webpack Module 2 error should still be there.
8. Open assets/scripts/main.js and remove trailing comma after aboutUs.
9. Save, manually refresh the BrowserSync window and ignore all errors.
10. Put the comma back (type it, not CTRL+Z it)
11. Save, manually refresh the BrowserSync window.
    All should be working perfectly fine. Edit $brand-primary: red for example and it should work.

Hope it helps troubleshooting!

[derkjn]

I was testing this today and I noticed that when running the production build, there's something wrong with how the ExtractTextPlugin handles the paths to the fonts.

To recreate the issue, you can simply add <i class="fa fa-cog"></i> to any of your templates and open the page. You'll notice the following error in the console :

This issue is resolved if I remove the publicPath: '../', configuration for css and scss from my webpack.config.js file.
Not sure exactly what's going wrong there but definitely something to look into!

[retlehs]

@derkjn unable to reproduce. please post on https://discourse.roots.io/ if you need further support

[derkjn]

@retlehs Thanks for replying, this got fixed with #1815 . Thank you!