Skip to content

Commit

Permalink
Allow debugger statements in development JS
Browse files Browse the repository at this point in the history
fixes #1480
  • Loading branch information
austinpray committed Jun 4, 2015
1 parent 71c2e78 commit d84d581
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
### HEAD
* Add search templates ([#1459](https://github.com/roots/sage/issues/1459))
* Allow `debugger` statements in development JavaScript ([#1480](https://github.com/roots/sage/issues/1480))

### 8.2.1: May 7th, 2015
* Update BrowserSync ([#1457](https://github.com/roots/sage/issues/1457))
Expand Down
14 changes: 11 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ var enabled = {
// Disable source maps when `--production`
maps: !argv.production,
// Fail styles task on error when `--production`
failStyleTask: argv.production
failStyleTask: argv.production,
// Fail due to JSHint warnings only when `--production`
failJSHint: argv.production,
// Strip debug statments from javascript when `--production`
stripJSDebug: argv.production
};

// Path to the compiled assets manifest in the dist directory
Expand Down Expand Up @@ -128,7 +132,11 @@ var jsTasks = function(filename) {
return gulpif(enabled.maps, sourcemaps.init());
})
.pipe(concat, filename)
.pipe(uglify)
.pipe(uglify, {
compress: {
'drop_debugger': enabled.stripJSDebug
}
})
.pipe(function() {
return gulpif(enabled.rev, rev());
})
Expand Down Expand Up @@ -221,7 +229,7 @@ gulp.task('jshint', function() {
].concat(project.js))
.pipe(jshint())
.pipe(jshint.reporter('jshint-stylish'))
.pipe(jshint.reporter('fail'));
.pipe(gulpif(enabled.failJSHint, jshint.reporter('fail')));
});

// ### Clean
Expand Down

0 comments on commit d84d581

Please sign in to comment.