Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force index.php as fallback template when using block themes #382

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

ssang
Copy link
Contributor

@ssang ssang commented Jun 19, 2024

Currently the index.html template will take precedence over any views that have names that should be higher in the template hierarchy. This is because currently, we only stack the files on top of the blade templates when in reality they should be grouped by template names.

I've only noticed this as an issue when trying to use home.blade.php as a template for the posts lists but it gets overridden by index.html even though that should be a fallback. Moving index.php to the end of the list when it exists should ensure that it is only used as a fallback and doesn't take precedence over custom view templates.

This is what the template hierarchy looks like right now

image

And this is what it should look like

image

@Log1x Log1x merged commit c2bc2ca into roots:main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants