Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external persistence storage #21

Closed
rogelio-blanco opened this issue May 27, 2022 · 1 comment
Closed

Add external persistence storage #21

rogelio-blanco opened this issue May 27, 2022 · 1 comment
Assignees
@rogelio-blanco

Comments

@rogelio-blanco
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The library has its own persistence mechanism which makes it very couple. We would like to provide some default behavior (using the current MongoDB implementation) but opened in case an external project uses a different persistence mechanism.

Ex:

  • The project wants to use a different DB engine.
  • The project wants to use its own MongoDB implementation.

Describe the solution you'd like
For those persistence-related methods, add an additional parameter (function) that executes the persistence operation.

Describe alternatives you've considered
I don't have any alternative ideas

Additional context
TBD
@rogelio-blanco rogelio-blanco self-assigned this May 27, 2022
rogelio-blanco pushed a commit that referenced this issue Jun 22, 2022
@rogelioblancoGL
Refactor #21 - Add external persistence storage
23c6a19 
- Clean code
- Fix package names
- Update project version
- Move Wallet extensions out of the interface
rogelio-blanco added a commit that referenced this issue Jun 22, 2022
@rogelio-blanco
Merge pull request #30 from roots-id/21-add-external-persistence-storage
49bb96f 
Refactor #21 - Add external persistence storage
rogelio-blanco pushed a commit that referenced this issue Jun 30, 2022
@rogelioblancoGL
Refactor #21 - Add external persistence storage
abd62b6 
- Create new interfaces to store objects in the persistence layer
- Create common interface for storage purposes
- Restructure code to different packages
rogelio-blanco added a commit that referenced this issue Jun 30, 2022
@rogelio-blanco
Merge pull request #31 from roots-id/21-add-external-persistence-storage
bdb0d51 
Refactor #21 - Add external persistence storage
rogelio-blanco added a commit that referenced this issue Aug 5, 2022
@rogelio-blanco @rogelioblancoGL
Refactor #21 - Add external persistence storage
927669d 
- Add new methods in the wallet service
- Adjust wallet storage to support new methods
rogelio-blanco pushed a commit that referenced this issue Aug 9, 2022
@rogelioblancoGL
Refactor #21 - Add external persistence storage
f202884 
- Store the operationHash, operationId and publish did operation status
- Create methods to return the operation status from the block chain
rogelio-blanco added a commit that referenced this issue Aug 9, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage
c092f49 
- Add new methods in the wallet service
- Adjust wallet storage to support new methods
- Store the operationHash, operationId and publish did operation status
- Create methods to return the operation status from the block chain
Essbante pushed a commit that referenced this issue Aug 10, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage (#33)
56c3aeb 
- Add new methods in the wallet service
- Adjust wallet storage to support new methods
- Store the operationHash, operationId and publish did operation status
- Create methods to return the operation status from the block chain
@rogelio-blanco
Copy link
Contributor Author

Refactor completed

Essbante pushed a commit that referenced this issue Aug 27, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage
a8feef3 
- Clean code
- Fix package names
- Update project version
- Move Wallet extensions out of the interface
Essbante pushed a commit that referenced this issue Aug 27, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage
5430d97 
- Create new interfaces to store objects in the persistence layer
- Create common interface for storage purposes
- Restructure code to different packages
Essbante pushed a commit that referenced this issue Aug 27, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage (#33)
387b88b 
- Add new methods in the wallet service
- Adjust wallet storage to support new methods
- Store the operationHash, operationId and publish did operation status
- Create methods to return the operation status from the block chain
rogelio-blanco added a commit that referenced this issue Aug 28, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage
0a82b48 
- Clean code
- Fix package names
- Update project version
- Move Wallet extensions out of the interface
rogelio-blanco added a commit that referenced this issue Aug 28, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage
3d1cd84 
- Create new interfaces to store objects in the persistence layer
- Create common interface for storage purposes
- Restructure code to different packages
rogelio-blanco added a commit that referenced this issue Aug 28, 2022
@rogelio-blanco
Merge pull request #30 from roots-id/21-add-external-persistence-storage
3dc69df 
Refactor #21 - Add external persistence storage
rogelio-blanco added a commit that referenced this issue Aug 28, 2022
@rogelio-blanco
Merge pull request #31 from roots-id/21-add-external-persistence-storage
2d9ca37 
Refactor #21 - Add external persistence storage
rogelio-blanco added a commit that referenced this issue Aug 28, 2022
@rogelio-blanco
Refactor #21 - Add external persistence storage (#33)
a570c3b 
- Add new methods in the wallet service
- Adjust wallet storage to support new methods
- Store the operationHash, operationId and publish did operation status
- Create methods to return the operation status from the block chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogelio-blanco rogelio-blanco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogelio-blanco