Print value fixes and removal of the old code #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perovic
force-pushed
the
PrintValueFixes
branch
from
3df9191 to
426c6b7
Compare
added 10 commits
August 18, 2015 11:03
Using fully qualified name in new printType_New method.
… and general fallback deals with this now). Moved isAddressValid function from Value.cpp to ValuePrinter.cpp and implemented the check for void*.
Minor comment fixes.
…e::GetFullyQualifiedName(QualifiedType, ASTCtx).
perovic
force-pushed
the
PrintValueFixes
branch
from
ee85b66 to
a86db5f
Compare
|
Merged into master - congrats & thanks! |
| str = str + printValue(*iter); | ||
| ++iter; | ||
| if (iter != iterEnd) { | ||
| str = str + ", "; |
There was a problem hiding this comment.
str += ", "; - several occurrences.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print value fixes introduced based on comments after the first pull request.
Removed the old code and made various changes to make the code simpler.