[cxxmodules] Load the dependent modules for both rootcling and rootcling_stage1 #5443
Conversation
|
Starting build on |
vgvassilev
force-pushed
the
load_dependent_modules
branch
from
ec27c15
to
7a69c1b
Compare
|
Starting build on |
|
Build failed on ROOT-fedora29/python3. Errors:
|
|
Build failed on ROOT-fedora31/noimt. |
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. |
|
Starting build on |
|
Build failed on mac1015/cxx17. Errors:
|
|
Starting build on |
|
Build failed on ROOT-fedora30/cxx14. Failing tests: |
|
@Axel-Naumann, weren't these failures in the master and then fixed? |
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
|
I'm not aware of them being fixed. We have a report that might be related, https://sft.its.cern.ch/jira/browse/ROOT-10629 |
|
Should we proceed with this PR and then fix the failures as we will have a reproducer? |
|
Build failed on mac1015/cxx17. Failing tests: |
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
|
Build failed on mac1015/cxx17. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
@phsft-bot build just on ROOT-fedora30/cxx14 with flags -DCMAKE_BUILD_TYPE=Debug -DLLVM_BUILD_TYPE=Debug I fail to reproduce this issue locally. Let's try to debug it at the bot. |
|
Starting build on |
|
Build failed on ROOT-fedora30/cxx14. Errors:
|
|
@phsft-bot build just on ROOT-fedora30/cxx14 with flags -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_BUILD_TYPE=RelWithDebInfo |
|
Starting build on |
|
Build failed on ROOT-fedora30/cxx14. Errors:
|
cat repro.C
#include <vector>
template <typename T>
struct Template {
Template() {}
private:
T m[12];
};
struct S {
std::vector<Template<float> > use;
};
template class Template<std::vector<float> >;
void repro() {}
This reproduces the problem. It is seen only on |
|
@vgvassilev I think most dependent PRs are merged, so this PR could be simplified... |
We might have an instantiation around, and the exception spec type
is only available if we have deserialized it. Force deserialization
which will update the EST. We certainly know that we will not
CodeGen and uninstantiated decl.
This patch fixes an assertion in codegen:
"CGCleanup.h:584: void clang::CodeGen::EHScopeStack::popTerminate(): Assertion `!empty() && "popping exception stack when not empty"' failed.
Aborted (core dumped)"
It is minimally reproducible by:
cat repro.C
template <typename T>
struct Template {
Template() {}
private:
T m[1];
};
std::vector<Template<int> > use;
//std::vector<float>f;
template class Template<std::vector<float> >;
void repro() {}
on fedora-30 with build config:
cmake -DCMAKE_BUILD_TYPE="Debug" -DCMAKE_CXX_FLAGS="-UNDEBUG"
-DCMAKE_CXX_STANDARD="14" -DCMAKE_INSTALL_PREFIX="../install"
-DLLVM_BUILD_TYPE="Debug" -Dalien="Off" -Darrow="Off" -Dasimage="On"
-Dbuiltin_afterimage="On" -Dbuiltin_cfitsio="Off" -Dbuiltin_davix="On"
-Dbuiltin_fftw3="Off" -Dbuiltin_freetype="Off" -Dbuiltin_ftgl="On"
-Dbuiltin_gl2ps="On" -Dbuiltin_glew="On" -Dbuiltin_gsl="Off" -Dbuiltin_lz4="On"
-Dbuiltin_lzma="On" -Dbuiltin_openssl="Off" -Dbuiltin_pcre="On"
-Dbuiltin_tbb="On" -Dbuiltin_unuran="On" -Dbuiltin_vc="On" -Dbuiltin_vdt="On"
-Dbuiltin_veccore="On" -Dbuiltin_xrootd="On" -Dbuiltin_xxhash="On"
-Dbuiltin_zlib="On" -Dbuiltin_zstd="Off" -Dccache="ON" -Dcefweb="Off"
-Dclad="On" -Dcocoa="Off" -Dcuda="Off" -Dcudnn="Off" -Ddataframe="On"
-Ddavix="On" -Ddcache="Off" -Ddev="Off" -Dfail-on-missing="On" -Dfcgi="Off"
-Dfftw3="On" -Dfitsio="On" -Dfortran="On" -Dgdml="On" -Dgfal="Off"
-Dgsl_shared="Off" -Dgviz="Off" -Dhttp="On" -Dimt="On" -Dlibcxx="Off"
-Dmathmore="On" -Dmemstat="Off" -Dminuit2="On" -Dmlp="On" -Dmonalisa="Off"
-Dmpi="Off" -Dmysql="On" -Dodbc="Off" -Dopengl="On" -Doracle="Off" -Dpgsql="On"
-Dpyroot="On" -Dpythia6="Off" -Dpythia6_nolink="Off" -Dpythia8="On"
-Dqt5web="Off" -Dr="Off" -Droofit="On" -Droottest="ON" -Dshadowpw="On"
-Dsoversion="On" -Dspectrum="On" -Dsqlite="On" -Dssl="On" -Dtesting="ON"
-Dtmva="On" -Dtmva-cpu="On" -Dtmva-gpu="Off" -Dtmva-pymva="On" -Dtmva-rmva="Off"
-Dunuran="On" -Dvc="On" -Dvdt="On" -Dveccore="On" -Dvecgeom="Off" -Dvmc="On"
-Dwin_broken_tests="Off" -Dx11="On" -Dxml="On" -Dxrootd="On"
/build/workspace/root-pullrequests-build-vvasilev/root -G Ninja
vgvassilev
force-pushed
the
load_dependent_modules
branch
from
eb0c75f
to
b39a6ba
Compare
|
Starting build on |
|
Build failed on mac1015/cxx17. Failing tests:
|
|
Build failed on ROOT-fedora29/python3. Failing tests: |
Fail with
Fail with Both seem unrelated to this PR. |
|
Build failed on ROOT-fedora30/cxx14. Failing tests: |
|
Fedora failures are not unrelated... |
|
@oshadura , cms-sw/cmsdist#5791 should include this root change in cmssw. Hopefully in tonight's 23h IB |
|
@davidlange6 may want his change to be integrated tonight first and maybe the next round? |
cc: @oshadura, @davidlange6, @smuzaffar