-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small clean-up in TSpectrum* #151
Conversation
Hi, I see you suppressed all the code related to "fResolution". I agree it might be not used but doing that you changed the calling sequence of some constructors. That will trigger some backward incompatibility. Is it really important for you to clean up it that way ? ... Let us know. Olivier |
I see. I did not realize this might cause issues with backward compatibility. I did this because of the confusion I can update the patch and leave the function declarations as they are, but make a note in the comments, remove the |
One other possibility would be to simply add a comment saying that fResolution is not used right now and could be used/implemented later. |
OK. I will do that and update the patch. |
This reverts commit 86338ea.
Fix conflict in hist/spectrum/src/TSpectrum.cxx comment to docs
I updated the pull request per your comments. |
Thanks. Update done. |
Quick question about the examples in the |
There is a Jira issue about this file https://sft.its.cern.ch/jira/browse/ROOT-6408 |
SetResolution
function andfResolution
member from theTSpectrum*
classes.*.ps.gz
papers and the "manual".