Skip to content

Commit

Permalink
Make tests fail if ASan finds an errors (#10005)
Browse files Browse the repository at this point in the history
The AddressSanitizer also loads the LeakSanitizer flags and even though
the documentation suggests that exitcode can be set per sanitizer, this
doesn't appear to be the case and our tests exit with code 0 after the
AddressSanitizer found a problem. After this change, around 100 tests
will fail due to several issues.
  • Loading branch information
hahnjo authored Mar 7, 2022
1 parent ffb1e4d commit b6be38f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/sanitizer/SanitizerSetup.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const char* __asan_default_options() {
/// These can be overridden / augmented by the LSAN_OPTIONS environment variable.
/// Using LSAN_OPTIONS=help=1 and starting an instrumented ROOT exectuable, available options will be printed.
const char* __lsan_default_options() {
return "exitcode=0:max_leaks=10:print_suppressions=1";
return "max_leaks=10:print_suppressions=1";
}

/// Default suppressions for leak sanitizer in ROOT.
Expand Down

0 comments on commit b6be38f

Please sign in to comment.