cleanup

root-project · Nov 30, 2024 · 461f316 · 461f316
1 parent c6e13dd
commit 461f316
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml
@@ -77,7 +77,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  conditional_job_check_files:
+  git_diff:
     name: Detect changes in Cling
     # https://www.meziantou.net/executing-github-actions-jobs-or-steps-only-when-specific-files-change.htm
     runs-on: ubuntu-latest
@@ -105,7 +105,7 @@ jobs:
         echo "interpreter_changed=$HasDiff"
 
   build-macos:
-    needs: [ conditional_job_check_files ]
+    needs: [ git_diff ]
     # For any event that is not a PR, the CI will always run. In PRs, the CI
     # can be skipped if the tag [skip-ci] or [skip ci] is written in the title.
     if: |
@@ -134,7 +134,8 @@ jobs:
             overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_CXX_STANDARD=20"]
           - platform: mac-beta
             arch: ARM64
-            overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_CXX_STANDARD=20", "clingtest=${{needs.conditional_job_check_files.outputs.interpreter_changed == 'true' && 'ON' || 'OFF'}}"] # https://stackoverflow.com/questions/76292948/github-action-boolean-input-with-default-value
+            overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_CXX_STANDARD=20", "clingtest=${{needs.git_diff.outputs.interpreter_changed == 'true' && 'ON' || 'OFF'}}"]
+            # https://stackoverflow.com/questions/76292948/github-action-boolean-input-with-default-value
 
     runs-on: # Using '[self-hosted, ..., ...]' does not work for some reason :)
       - self-hosted
@@ -366,7 +367,7 @@ jobs:
 
 
   build-linux:
-    needs: [ conditional_job_check_files ]
+    needs: [ git_diff ]
     # For any event that is not a PR, the CI will always run. In PRs, the CI
     # can be skipped if the tag [skip-ci] or [skip ci] is written in the title.
     if: |
@@ -397,7 +398,8 @@ jobs:
           - image: alma8
             overrides: ["LLVM_ENABLE_ASSERTIONS=On"]
           - image: alma9
-            overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_BUILD_TYPE=Debug", "clingtest=${{needs.conditional_job_check_files.outputs.interpreter_changed == 'true' && 'ON' || 'OFF'}}"] # https://stackoverflow.com/questions/76292948/github-action-boolean-input-with-default-value
+            overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_BUILD_TYPE=Debug", "clingtest=${{needs.git_diff.outputs.interpreter_changed == 'true' && 'ON' || 'OFF'}}"]
+            # https://stackoverflow.com/questions/76292948/github-action-boolean-input-with-default-value
           - image: ubuntu22
             overrides: ["imt=Off", "LLVM_ENABLE_ASSERTIONS=On", "CMAKE_BUILD_TYPE=Debug"]
           - image: ubuntu2404