Fix: Allow anonymous download when NoAnonymousUploads is set #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the option NoAnonymousUploads is set, any access to the web front end page will result in a login page even if the login is not requested by the server. This is an issue when a user wants to assess a download page (in /#?id=dowloadId) So this commit disables the login check in the plik frontend client if the page is a download page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
First I want to say thank you for your time and effort to build this project with so many features!
When I set the server up, I run into an issue.
It seems like the plik web client prevent user to list downloadable files even if the server allow it.
The bug can be reproduced by doing the following steps:
The correct behavior would be to not redirect the user to the login page.
The patch is exactly doing that: If the page is a download page, consider that the user do not need to login.
If you have any question feel free to ask!