Updated elgohr/Publish-Docker-Github-Action to a supported version (v5) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor starts working
…icient number of disks with required size
This reverts commit d71e774.
This reverts commit 62a33ec.
…nd. the change will take place after RCHOS reboot
This should allow specifying different image tag for each image
change Enable host to new state machine model Add GenerateErrorResponderWithDefault to error utils, if err is api error then return it else generated new error by the default code that passed
Updated BUILD_FOLDER permission in the swagger-codegen-cli container
Bucket creation will be defaulted to "false" and created only on demand. In integration env we don't have permissions to create buckets so we can't always create it. Signed-off-by: Yoni Bettan <[email protected]>
Previously many of these tests could fail if over three minutes elapsed between when the array of test cases was defined and when any individual test was run. This is because the host `CheckedInAt` time was defined as time.Now() in the test case definition, not when the test was actually being run. This was happening in two contexts. One was "All transitions" where some cases were relying on the check-in time to be out of range (unset) and others needed it to be within the last 3 minutes. The other was the "Unique hostname" context where all the tests were using time.Now() so I removed the test case parameter for that one.
If this isn't meant to be committed it would be nice to not see it in `git status`.
At this point the pkg contains only a struct grouping all DB fields and making use of this struct instead of listing all individual fields separately. Signed-off-by: Yoni Bettan <[email protected]>
…HW requirement checks
Allow canceling or resetting installation from preparing-for-installation state. Added subsystem-test.
This change is done in order to be as close as possible to the integration environment which deploy Postgres and its corresponding secret which contain its credentials. Now the credentials for connecting to DB comes from `assisted-installer-rds` secret in `assisted-istaller` namespace. Signed-off-by: Yoni Bettan <[email protected]>
The values of DBConfig fields comes from a secret, if the deployment isn't using this secret correctly we want to make sure that subsystem tests are failing instead of succeeding by using correct credentials originated from default values. Signed-off-by: Yoni Bettan <[email protected]>
This change is done in order to be as close as possible to the integration environment which deploy S3 and its corresponding secret which contain its credentials. Now the credentials for connecting to S3 comes from assisted-installer-s3 secret in assisted-istaller namespace. Signed-off-by: Yoni Bettan <[email protected]>
The values of S3Config fields comes from a secret, if the deployment isn't using this secret correctly we want to make sure that subsystem tests are failing instead of succeeding by using correct credentials originated from default values. Signed-off-by: Yoni Bettan <[email protected]>
Signed-off-by: Amador Pahim <[email protected]>
Now the current deployment will run `bm-inventory`'s code instead of a busy box. Signed-off-by: Yoni Bettan <[email protected]>
Now a Service should be deployed in addition to `bm-inventory` pod in the integration environment. Signed-off-by: Yoni Bettan <[email protected]>
bm-inventory was renamed to assisted-service when moving to Openshift org. Signed-off-by: Yoni Bettan <[email protected]>
This ServiceAccount was authorized to create Jobs within the same namespace, we need it so `assisted-service` can create `dummy-image` job without errors. Signed-off-by: Yoni Bettan <[email protected]>
Signed-off-by: Yoni Bettan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elgohr/Publish-Docker-Github-Action@master is not supported anymore