Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version downgrades, bump msrv to 1.46.0 #355

Closed
wants to merge 3 commits into from
Closed

Remove version downgrades, bump msrv to 1.46.0 #355

wants to merge 3 commits into from

Conversation

torkleyy
Copy link
Contributor

  • I've included my change in CHANGELOG.md

Fixes #347

juntyr
juntyr approved these changes Dec 27, 2021
View reviewed changes
Cargo.toml Show resolved Hide resolved
juntyr
juntyr requested changes Dec 29, 2021
View reviewed changes
Copy link
Member

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also resolve the // TODO: use fXX::EPSILON when minimum supported rust version is 1.43 comments in this MSRV bump?

@enfipy
Copy link

enfipy commented Jan 27, 2022 •
edited
Loading

We are also blocked by this. May we push this forward? ❤️

@juntyr
Copy link
Member

juntyr commented Jan 28, 2022 •
edited
Loading

We are also blocked by this. May we push this forward? ❤️

@enfipy As @torkleyy seems to be busy at the moment, I'll update the PR and get it merged today.

@juntyr juntyr mentioned this pull request Jan 28, 2022
Merged
1 task
@juntyr
Copy link
Member

juntyr commented Jan 28, 2022

Superseded by #361

@juntyr juntyr closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juntyr juntyr juntyr requested changes

@kvark kvark Awaiting requested review from kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert #340
3 participants
@torkleyy @enfipy @juntyr