Deserializer rework #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Aug 1, 2017
|
r=me when ready |
|
Awesome work, |
!
|
🔒 Permission denied Existing reviewers: click here to make kvark a reviewer |
|
sudo
bors r+
… On Aug 2, 2017, at 11:29, bors[bot] ***@***.***> wrote:
🔒 Permission denied
Existing reviewers: click here to make kvark a reviewer
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
Aug 2, 2017
27: Deserializer rework r=kvark This PR gets rid of the parser (POM). The goal is to make deserialization faster and avoid unnecessary dependencies. It seems that RON is simple enough to be parsed without some framework; these libraries tend to have `Box<Fn>` and `Vec` all over the place.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the parser (POM). The goal is to make deserialization faster and avoid unnecessary dependencies. It seems that RON is simple enough to be parsed without some framework; these libraries tend to have
Box<Fn>andVecall over the place.