Optionally always include float decimals #237
Conversation
|
Also, I'd love to use rust's fmt syntax to tack on the |
src/ser/mod.rs
Outdated
| @@ -363,11 +388,17 @@ impl<'a, W: io::Write> ser::Serializer for &'a mut Serializer<W> { | |||
|
|
|||
| fn serialize_f32(self, v: f32) -> Result<()> { | |||
| write!(self.output, "{}", v)?; | |||
| if self.decimal_floats() && v - v.floor() == 0.0 { | |||
There was a problem hiding this comment.
why isn't this written as v == v.floor()?
There was a problem hiding this comment.
No reason. Your representation is clearly better 😄
tests/floats.rs
Outdated
| #[test] | ||
| fn decimal_floats() { | ||
| let pretty = PrettyConfig::new().with_decimal_floats(false); | ||
| let without_decimal = to_string_pretty(&1.0, pretty).expect("Serialization failed"); |
There was a problem hiding this comment.
Do we need those expect strings here? For tests, I think unwrap is perfectly fine.
There was a problem hiding this comment.
I was following the pattern in the "preserve_sequence" tests, but I'm happy to swap these out. "preserve_sequence" appears to be the only existing test that uses expect.
cart
force-pushed
the
decimal_floats
branch
2 times, most recently
from
33c5539
to
d9a8305
Compare
|
Note: clippy isn't happy with float comparisons (red on CI) |
|
i opted for the clippy recommended solution: |
|
oops :) |
|
It looks like EPSILON associated constants aren't in 1.34. Is backward compat desirable? I can either inline the epsilon values or someone will need to bump that version to 1.43. What should I do here? |
|
Let's not raise the Rust version just yet. Debian and other distros are typically much behind the top of the tree. |
This adds the option to always include the decimal point in floats.
Currently ron always serializes
5.0as5. I have a use case that makes the5vs5.0distinction important. My rust type is a dynamic collection that can contain either floats or ints. Round tripping a value of5.0with ron results in an integer output of5when its source was a float.