-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inf, -inf and NaN handling #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
One suggestion is left. Also let's give @torkleyy a bit of time to check this out if they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might work, but I have one concern.
Please rebase instead of merge committing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
bors r+
163: Implement inf, -inf and NaN handling r=torkleyy a=artemshein FIxes #159 Co-authored-by: Artem Shein <[email protected]>
Um, bors? |
pong |
bors r+ |
163: Implement inf, -inf and NaN handling r=torkleyy a=artemshein FIxes #159 Co-authored-by: Artem Shein <[email protected]>
Build succeeded |
FIxes #159