!perf: Use string for iteration and error reporting #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
string
type is smaller than a[]byte
and can be copied much faster. Copying structs <= 32 bytes on modern 64-bit systems is essentially free whereasError[[]byte]
is 40 bytes widemaking jscan work faster with
string
than with[]byte
. This PR eliminates the overhead at the cost of backward compatibility improving performance by about 14%.unsafe
.Error
:Src
.Error
is no longer required to be type-parameterized.An alternative solution is presented in #25.
Benchmark results: