misc: avoid using unserialize when caching NULL default values

romm · Jun 6, 2023 · 5e9b4ce · 5e9b4ce
1 parent 0a8f37b
commit 5e9b4ce
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/Definition/Repository/Cache/Compiler/ParameterDefinitionCompiler.php b/src/Definition/Repository/Cache/Compiler/ParameterDefinitionCompiler.php
@@ -6,8 +6,6 @@
 
 use CuyZ\Valinor\Definition\ParameterDefinition;
 
-use function is_scalar;
-
 /** @internal */
 final class ParameterDefinitionCompiler
 {
@@ -42,8 +40,8 @@ private function defaultValue(ParameterDefinition $parameter): string
     {
         $defaultValue = $parameter->defaultValue();
 
-        return is_scalar($defaultValue)
-            ? var_export($parameter->defaultValue(), true)
-            : 'unserialize(' . var_export(serialize($defaultValue), true) . ')';
+        return is_object($defaultValue)
+            ? 'unserialize(' . var_export(serialize($defaultValue), true) . ')'
+            : var_export($defaultValue, true);
     }
 }