Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_formatter): jsx whitespace is meaningful jsx text #3732

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

denbezrukov
Copy link
Contributor

Summary

Partial fix #3531

function Component3() {
  return (
    <div>
      {fn(data)}{' '}
      <Component />
    </div>
  );
}

function Component4() {
  return (
    <div>
      {fn(datadatadatadatadatadatadatadatadatadatadatadatadatadatadatadata)}{' '}
      <Component />
    </div>
  );
}

Prettier transforms {' '} in JSXText which is a meaningful text.

Test Plan

cargo test -p rome_js_formatter

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ef38b04
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6372bb89fb53c80009e4779f

@MichaReiser MichaReiser added the A-Formatter Area: formatter label Nov 15, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 15, 2022
@MichaReiser MichaReiser merged commit 875f4fb into rome:main Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Various spacing/line length formatting incompatibilities with Prettier
2 participants