Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyzer): noInvalidConstructorSuper false positive for class expressions #3561

Merged
merged 2 commits into from
Nov 7, 2022
Merged

fix(rome_js_analyzer): noInvalidConstructorSuper false positive for class expressions #3561

merged 2 commits into from
Nov 7, 2022

Conversation

lucasweng
Copy link
Contributor

Summary

Test Plan

Added new test cases for export declarations

@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for docs-rometools failed.

Name Link
🔨 Latest commit 8335a0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/636853bb8114fa000875d582

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a new case in the documentation of the rule?

@lucasweng lucasweng requested a review from a team November 5, 2022 00:44
@lucasweng
Copy link
Contributor Author

Sure, no problem! 1a23ca2

Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please resolve the merge conflicts by rebasing on main and running cargo lintdoc.

@MichaReiser MichaReiser merged commit 5432238 into rome:main Nov 7, 2022
@lucasweng lucasweng deleted the fix/no-invalid-constructor-super branch November 8, 2022 01:15
jeysal added a commit to jeysal/rometools that referenced this pull request Nov 8, 2022
* upstream/main:
  fix(ci): fix the release workflows for the stable release (rome#3583)
  Fix logo container margin
  Fix mobile docs regressions
  perf: End-to-end Linter and Formatter benchmarks (rome#3570)
  doc: VS Code extension (rome#3579)
  refactor(rome_cli): refactor the threading of parallel traversal to increase occupancy (rome#3577)
  [docs] Add navigation dropdown for docs (rome#3578)
  doc(rome_cli): Document `--files-max-size` option
  perf(rome_js_semantic): Use FX Hash function (rome#3565)
  fix(rome_js_analyzer): `noInvalidConstructorSuper` false positive for class expressions (rome#3561)
  Clean up mobile navigation
  doc(website): Run `cargo lintdoc` (rome#3567)
  doc: Fix install command
  Fix mobile code blocks
  Fix dark mode logo
  Update links
  Implement new website (rome#3556)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 noInvalidConstructorSuper false positive for class expressions
3 participants