Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

chore(rome_service): remove constraints from settings #3157

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

ematipico
Copy link
Contributor

Summary

This PR is a follow up of #3123

This PR removes all the constraints that we have inside the WorkspaceSettings. Now the settings are not publicly exposed anymore, so we can remove all the serde/schemars macros. This will allow to have more choice with the data structures we want to choose.

Test Plan

This is an internal refactor, so the existing CI should pass.

@ematipico ematipico temporarily deployed to netlify-playground September 5, 2022 09:26 Inactive
@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit d47ef55
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6315c0c1f2b14c000829d467

@ematipico ematipico added the A-Core Area: core label Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

@MichaReiser
Copy link
Contributor

Would you mind explaining what you mean by "constraints"

removes all the constraints

@ematipico
Copy link
Contributor Author

Would you mind explaining what you mean by "constraints"

removes all the constraints

WorkspaceSettings was tagged with serde::Deserialize and serde::Serialize, which means we could only choose data structures that are already serializable/de-serializable or data structures that require custom function to serialize/de-serialize them. So in a sense it was a constrain/bump.

Now that we don't need serde here, we can choose all the data structures that we see fit without worrying about their serialization/de-serialization.

@ematipico ematipico added this to the 0.10.0 milestone Sep 5, 2022
@ematipico ematipico merged commit 96ce01c into main Sep 6, 2022
@ematipico ematipico deleted the chore/remove-constraints branch September 6, 2022 15:37
@ematipico ematipico removed this from the 0.10.0 milestone Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Core Area: core
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants