This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
chore(rome_service): remove constraints from settings #3157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up of #3123
This PR removes all the constraints that we have inside the
WorkspaceSettings
. Now the settings are not publicly exposed anymore, so we can remove all the serde/schemars macros. This will allow to have more choice with the data structures we want to choose.Test Plan
This is an internal refactor, so the existing CI should pass.