This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Добавила OAuth авторизацию #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarith
reviewed
Dec 19, 2022
| useEffect(() => { | ||
| isOAuth() |
There was a problem hiding this comment.
nit: функции обычно именуют с глагола, а is/has/... используются для булевых значений
|
|
||
| export const useServiceId = () => { | ||
| const dispatch = useAppDispatch() | ||
| const REDIRECT_URI = 'http://localhost:3000'; |
There was a problem hiding this comment.
В 9м спринте понадобится подставлять продовый или дев-адрес в зависимости от окружения. Это будет сложно сделать, если константа дублируюется в нескольких местах
There was a problem hiding this comment.
Когда настроим докер контейнер и впишем авторизацию в серверный рендеринг - поправлю этот момент
There was a problem hiding this comment.
В целом можно было бы сразу вынести общую константу, но не настаиваю
jarith
approved these changes
Dec 20, 2022
Arkadiy2907
approved these changes
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавила OAuth авторизацию, использовала хуки useServiceId и useOAuth:
Скриншоты/видяшка (если есть)
TBD (если есть)