Use the most recent window to make quickfix jumps #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins - for example, tpope's fugitive - trigger custom QuickFixCmdPost events using :doautocmd. This causes some commands - for example, :Glgrep - to trigger inappropriate calls to qf#OpenQuickfix when they should be triggering qf#OpenLoclist, due to the way qf.vim determines which list to open (by command name). To solve this, we can cache the value of getqflist() on QuickFixCmdPre, and check it again on QuickFixCmdPost. If the value has changed, we know to call qf#OpenQuickfix. Otherwise, we call qf#OpenLoclist. This should allow for seamless integration with these sorts of plugin commands, without having to know or care about their names.
|
@romainl I've gone ahead and found a different, cleaner approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always bothered me that the default vim behaviour was to use whatever unrelated window lay at the bottom of the screen to make quickfix jumps. This small patch changes that behaviour so that your first jump after running a quickfix command leaves you in the same window, and furthermore, if you do something like
copento navigate the quickfix window, pressing<Return>will jump you back in the previous window.