Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix site #135

Merged
merged 1 commit into from
May 21, 2018
Merged

[WIP] fix site #135

merged 1 commit into from
May 21, 2018

Conversation

Rich-Harris
Copy link
Contributor

Seems some dependencies are no longer playing nicely with each other, and there was no lockfile. Bringing everything up to date is taking a while and I've run out of time for now, but will come back to this later

@lukastaegert
Copy link
Member

Is this in any shape to be merged at the moment? I suppose since the website is broken anyway, there is no danger it is getting worse...

@Rich-Harris
Copy link
Contributor Author

I guess so... the REPL is broken but the guide works

@lukastaegert lukastaegert merged commit 0be93bf into master May 21, 2018
@lukastaegert
Copy link
Member

I took a shot at merging but it seems there still is an issue probably with the SSR :(

@lukastaegert
Copy link
Member

@Rich-Harris Ok, an update here:

I ended up reverting the merge and force-pushing to master—sorry if this caused any inconvenience for anyone. Thus this branch should NOT BE DELETED but probably used as the basis for a new PR to update the dependencies, otherwise these commits might be lost.

The website and REPL are working again for now. What I did:

  • Add a yarn lock-file (seemed to work better than npm)
  • Downgrade svelte-loader to the exact version 2.3.3 (no auto-update)

If the dependencies are eventually updated (which I really hope they are), it seems there is an issue in the latest version of svelte-loader that does not seem to trigger locally but triggers on deployment. Really nasty. It might make sense checking the latest changes to this loader and comparing with the stack-trace of the error which can be found e.g. here: #134 .

@vladshcherbin
Copy link

@lukastaegert this one is related I guess: sveltejs/svelte-loader#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants