This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
fix(): make empty.js virtual #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition, it modernizes the code a little bit, but using Map() and avoiding excessive branches. |
lukastaegert
suggested changes
Jun 16, 2019
src/index.js
Outdated
|
|
||
| const ES6_BROWSER_EMPTY = resolve( __dirname, '../src/empty.js' ); | ||
| const ES6_BROWSER_EMPTY = '!node-resolve:empty.js'; |
There was a problem hiding this comment.
As this is kind of a private module, I would assume it should be prefixed with \0 instead to avoid other plugins from messing with it, e.g. by inserting code?
There was a problem hiding this comment.
@lukastaegert fixed!
|
Really like the changes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At stencil we try to make rollup and this plugin to work in the browser, in addition, we bundle rollup-plugin-node-resolve into the stencil's bundle. The fact that
empty.jsis a read file within the file system makes it harder in some cases.This PR solves that by making the empty.js file a virtual module.