-
Notifications
You must be signed in to change notification settings - Fork 86
replace buble with babel, update deps #216
replace buble with babel, update deps #216
Conversation
Should I create another PR where I update dependencies? Can I update those inside this PR? |
Definitely! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should actually add something like babel-preset-env and the target version of Node 6? Then we can easily update to Node 8 in the future once the time has come and provide the best output possible while maintaining compatibility. What do you think?
After those changes, I think we can rewrite sources to async-await syntax. It will be compiled to promises by babel then we just change target version to 8 ;) I already have a branch with refactored this package to async-await syntax. Should I send a PR? |
Sounds good! I assume it will also work for the tests via babel-register? |
I think yes. It already works with it. current mocha opts(with this PR):
|
SHould I add refactored to async-await version to this PR? |
Sure, sounds good, considering you already seem to have done the work. Just avoid |
I prefer to merge this PR as is. Then I add PR with refactored to async-await syntax. |
This PR is a part of changesets described here #213 (comment)