Treat sideEffects array as inclusion list (#227)

* Treat sideEffects array as inclusion list - Fixes #226 * Rename 'true-index' to 'array-index' for clarity * Inline unnecessary local variable * Rename test files from "-free" to "-effect"
rollup · Jun 22, 2019 · d49e257 · d49e257
1 parent cdb7448
commit d49e257
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -145,8 +145,7 @@ export default function nodeResolve ( options = {} ) {
 		if (typeof packageSideEffects === 'boolean') {
 			packageInfo.hasModuleSideEffects = () => packageSideEffects;
 		} else if (Array.isArray(packageSideEffects)) {
-			const filter = createFilter(packageSideEffects, null, {resolve: pkgRoot});
-			packageInfo.hasModuleSideEffects = id => !filter(id);
+			packageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {resolve: pkgRoot});
 		}
 
 		packageInfoCache.set(pkgPath, packageInfo);

diff --git a/...e_modules/side-effects-array/dep3-free.js → ...modules/side-effects-array/dep3-effect.js b/...e_modules/side-effects-array/dep3-free.js → ...modules/side-effects-array/dep3-effect.js
diff --git a/test/node_modules/side-effects-array/index.js b/test/node_modules/side-effects-array/index.js
diff --git a/...es/side-effects-array/nested/dep5-free.js → .../side-effects-array/nested/dep5-effect.js b/...es/side-effects-array/nested/dep5-free.js → .../side-effects-array/nested/dep5-effect.js
diff --git a/test/node_modules/side-effects-array/package.json b/test/node_modules/side-effects-array/package.json
diff --git a/test/test.js b/test/test.js
@@ -890,9 +890,10 @@ describe( 'rollup-plugin-node-resolve', function () {
 				'true-dep1',
 				'true-dep2',
 				'true-index',
-				'array-dep2',
-				'array-dep4',
-				'true-index'
+				'array-dep1',
+				'array-dep3',
+				'array-dep5',
+				'array-index'
 			]);
 			delete global.sideEffects;
 		}));