[!] Error: 'default' is not exported by ../../node_modules/prop-types/index.js

[samonxian]

rollup config

// rollup.config.js
import commonjs from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve';

export default {
  input: 'main.js',
  output: {
    file: 'bundle.js',
    format: 'umd',
    name: umdName,
    indent: false,
    sourcemap: false,
  },
  plugins: [
    nodeResolve(),
    commonjs({
      include: 'node_modules/**', // Default: undefined
    }),
  ],
};

When running rollup -c,it will throw the error.
I have been looking for this problem for a while, but there is no solution.
But when using commonjs without any options,it wok fine.

// rollup.config.js
import commonjs from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve';

export default {
  input: 'main.js',
  output: {
    file: 'bundle.js',
    format: 'umd',
    name: umdName,
    indent: false,
    sourcemap: false,
  },
  plugins: [
    nodeResolve(),
    commonjs(),
  ],
};

[TrySound]

@xianshannan Do you have monorepo?

[TrySound]

Try /node_modules/ regexp

[samonxian]

@TrySound I have monorepo.
I had try /node_modules/，but namedExports did not work.
It throws the error:
[!] Error: 'isValidElementType' is not exported by ../../node_modules/react-is/index.js

// rollup.config.js
import commonjs from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve';

export default {
  input: 'main.js',
  output: {
    file: 'bundle.js',
    format: 'umd',
    name: 'umdName',
    indent: false,
    sourcemap: false,
  },
  plugins: [
    nodeResolve(),
    commonjs({
      namedExports: {
        'node_modules/react-js/index.js': ['isValidElementType'],
      },
      include: [
        /node_modules\/prop-types/,
        /node_modules\/hoist-non-react-statics/,
        /node_modules\/invariant/,
        /node_modules\/react-is/,
        /node_modules\/warning/,
      ],
    }),
  ],
};

[TrySound]

I use names which I import from

      namedExports: {
        'react-js': ['isValidElementType'],
      },

[samonxian]

@TrySound Thanks, it did work.

[NathanielHill]

@TrySound Thanks for this! Finally realized my node modules being ../../ down from rollup's cwd was causing most of my problems!

[NathanielHill]

I wonder if there should be a note in the docs about monorepos? Most tools play nice with different node_modules location

[josefaidt]

@NathanielHill I'm having this exact same issue with a monorepo. Came to rollup for a react component library and a note like that would be incredibly helpful.

[NathanielHill]

@josefaidt Did you fix your problem?

[NathanielHill]

I created a pull request to update the docs with a note: #372

[josefaidt]

@NathanielHill No I have not. Using the include: /node_modules/ property did not work unfortunately.

[NathanielHill]

@josefaidt You also need to be careful about whether /node_modules/ is transpiled by babel or not. You can also use regexes there and I would advise that as well.

[josefaidt]

Ah that did it. Didn't think about the transpilation at first. I had to also add all of my dependencies to externals as shown below:

export default {
  input: './src/index.js',
  output: {
    file: './build/bundle.js',
    name: 'SomeModule',
    format: 'iife',
    sourcemap: 'inline',
  },
  plugins: [
    babel({
      plugins: babelPlugins,
      presets: babelPresets,
      exclude: /node_modules/,
    }),
    url(),
    postCss({ modules: true }),
    nodeResolve(),
    cjs({ include: /node_modules/ }),
  ],
  external: ['react', 'react-dom', 'prop-types', 'styled-components'],
}

[NathanielHill]

🎉 Exactly! There's a plugin to generate the externals automatically from package.json, but it didn't work for me at all, and apparently it doesn't support namespaced packages.

Would be nice if that worked.

[josefaidt]

Yes, thank you for your timely assistance! Thankfully this will be a relatively small library in terms of packages used, but I agree it would be nice to do it automatically.

[sunyongjian]

+1

namedExports always is not work, I have tried all the above methods.

[zhaowenjian]

+1 , is this a bug ? the rollup-plugin-commonjs doc about namedExports not useful?

[bwhitty]

To go with #361 (comment) and anyone else reading this (and maybe working in a monorepo), to fix prop-types fully, this works:

commonjs({
  // https://github.com/rollup/rollup-plugin-commonjs#usage-in-monorepo
  include: /node_modules/,
  namedExports: {
    // node_modules/prop-types/factoryWithTypeCheckers.js#L115
    'prop-types': [
      'array',
      'bool',
      'func',
      'number',
      'object',
      'string',
      'symbol',
      'any',
      'arrayOf',
      'element',
      'elementType',
      'instanceOf',
      'node',
      'objectOf',
      'oneOf',
      'oneOfType',
      'shape',
      'exact',
    ],
  },
}),

Alternatively, and against the suggestions of prop-types's, documentation, marking prop-types as a peerDependency (assuming you're bundling a package) and using rollup-plugin-peer-deps-external would work as well.

[AntonioRedondo]

I've been having an absolute inconsistent behaviour with the commonjs plugin and the include property. I had to play with these three values in order to Rollup to compile:

commonjs({
    include: [
        "node_modules",
        "node_modules/**",
        "node_modules/**/*",
    namedExports: { ... },
}),

Don't put all three, just use the one that makes namedExports working, mostly node_modules/** and node_modules/**/*.

[TrySound]

@AntonioRedondo RegEx is more universal here

commonjs({
  include: /node_modules/,
  namedExports: { ... }
})