Build TypeScript plugin with TypeScript 4 #674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name: all
This PR contains:
Are tests included?
Breaking Changes?
I don't expect this would cause folks issues in upgrading. The only code changes I had to make were slight and internal to the plugins, so I don't think the external types will change
Description
There are a number of open issues with the TypeScript plugin. I was poking around to see what would be required to fix some of them. Being on an older version of TypeScript makes things harder. E.g. it seems like there might be a bug in one of the TypeScript methods (#287 (comment)), but I can't report issues to the TypeScript team unless using the latest version of TypeScript. I also was trying to use an API that I saw in
tsc
and appeared to be exported, but VS Code is telling me it doesn't exist and I wonder if being on an older version of TypeScript might be why.