-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node-resolve): resolve hash in path #588
Conversation
This creates a bit of a special case, for instance it would not fix it for |
I agree this is definitely an improvement and could be released as a partial bug fix. But looking for a long term fix, why are we stripping BOTH I think it would still solve the original issue #486 in so far as it leaves a way to pass on information, just not via hashes. Thoughts @LarsDenBakker? |
I agree, ? Is the primary use case so we could leave out hashes. |
@chengcyber Would you be willing to modify this PR to remove the special handling for hashes altogether? Of course this would make this a breaking change, but I think this should be worth it in the long run. |
362a0c7
to
18acd47
Compare
@lukastaegert, I remove the special handling for hashes in the latest commit, please kindly take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can be merged
* fix(node-resolve): resolve hash in path * refact(node-resolve)!: remove special handling for hashes See rollup/plugins#588 (comment)
Rollup Plugin Name: @rollup/plugin-node-resolve
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This PR is fixing #587
treats as hash usage
treats
hash
as part of package path