Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nodejs esm interop #512

Closed

Conversation

frank-dspeed
Copy link
Contributor

@frank-dspeed frank-dspeed commented Jul 27, 2020

(!WIP) do not Merge

  • Fix: package.json module fild in all modules remove emit-package-file plugins as not needed anymore
  • Fix: add exports to every package.json
  • Fix: add individual emit-module-type-definition-file to fix problems inside vscode and or typescript so it find the type definitions for imported .mjs files

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This will fix the current situation that the plugins do not get imported as esm when using nodejs esm loader it also fixes typescript issues when importing the mjs version directly

The situation before was that the plugins got created with cjs in mind i now found out that they all did not work correct with typescript and nodejs esm interop in current nodejs and current vscode.

@shellscape
Copy link
Collaborator

Please see comments about PRs that affect more than one plugin in #507. We'd much prefer a single PR per plugin.

@frank-dspeed
Copy link
Contributor Author

Closing this in favor of my own rollup fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants