Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import with relative and absolute path -> file appears two times in bundle.js #296

Closed
masrlinu opened this issue Apr 3, 2020 · 10 comments
Closed

Comments

@masrlinu
Copy link

masrlinu commented Apr 3, 2020

  • Rollup Plugin Name: plugin-alias
  • Rollup Plugin Version: 3.0.1.0.2
  • Rollup Version: 1.32.1
  • Operating System (or Browser): Mac/Chrome
  • Node Version: 13.8.0

How Do We Reproduce?

if you include a file with a relative path:
import { file } from './file.js';
and somewhere else import it with an alias:
import { file } from 'alias/file.js';
the file appears two times in the bundle, one time as file and one time as file$1 and it also gets called two times. If I just use the relative path in both examples or the absolute path in both examples, the file appears there just one time and gets called just one time.

Expected Behavior

The js-import should just appear one time in the bundle.js and should not be called twice.

Actual Behavior

The imported js-file apperas twice in the bundle.js. One time as file and one time as file$1 and it gets called twice.

@shellscape
Copy link
Collaborator

Thanks for opening an issue. Citing the issue template:

Issues without minimal reproductions will be closed! Please provide one by:

  1. Using the REPL.it plugin reproduction template at https://repl.it/@rollup/rollup-plugin-repro
  2. Provide a minimal repository link (Read https://git.io/fNzHA for instructions).
    These may take more time to triage than the other options.
  3. Using the REPL at https://rollupjs.org/repl/

Please add a reproduction and we'll be happy to triage further.

@masrlinu
Copy link
Author

masrlinu commented Apr 3, 2020

Here is the reproduction:
https://repl.it/repls/SourYellowDataset

if you start
npm install
npm run dev

then the file public/build/bundle.js contains the following lines (the content of testLoadedTwice two times):

console.log('Hello!');
const testLoadedTwice = null;

console.log('Hello!');
const testLoadedTwice$1 = null;

@shellscape shellscape reopened this Apr 3, 2020
@shellscape
Copy link
Collaborator

Thanks

shellscape added a commit that referenced this issue Apr 26, 2020
* initial commit

* allow include/exclude

* admin and README

* -> 1.0.0

* fix prepublish script

* Update README.md

* make compatible with babel 6

* -> 2.0.0

* Merge pull request #6 from Victorystick/patch-1

Add repository

* Merge pull request #8 from TrySound/tidy-up

Tidy up

* -> 2.0.1

* remove unnecessary logging

* bump up timeout, to try and fix tests on 0.12

* generate sourcemaps by default

* -> 2.1.0

* test for #16

* run preflight check per file – fixes #16

* -> 2.2.0

* Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel

* debug travis test failure

* add missing devDep

* add appveyor config

* es6ify source code

* fix tests on windows?

* install babel-register

* Merge pull request #19 from rollup/gh-17

Better handling of helpers

* -> 2.3.0

* -> 2.3.2

* fix incomprehensible travis test failure

* fix helper renaming (#22)

* -> 2.3.3

* fix failing preflight check in absence of class transformer (closes #23)

* -> 2.3.4

* Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel

* use class transformer local to plugin

* -> 2.3.5

* typo

* verify warnings are correct

* prevent unnecessary `var babelHelpers = {}`

* update rollup

* Merge pull request #29 from rollup/fix-preflight-check-caching

Ensure caching works properly for repeated calls with the same `dir`.

* -> 2.3.6

* remove some debugging code

* Merge pull request #31 from ericf/fix-babel-helper-bindings

Fix Babel helper binding renaming

* -> 2.3.7

* -> 2.3.8

* external-helpers-2 -> external-helpers

* Merge remote-tracking branch 'ericf/remove-babel-helper-renaming'

* -> 2.3.9

* Update README.md

* Merge pull request #41 from joeldenning/external-helpers

Adding support for referencing external, global helpers

* -> 2.4.0

* import helpers, so that transform function is pure

* update test

* update deps, switch from babel to buble

* -> v2.5.0

* install buble

* Merge pull request #57 from rollup/mocha-opts

Extract mocha options into their own file.

* Merge pull request #56 from rollup/gh-55

typeof

* -> v2.5.1

* Update dependencies.

* dont export _typeof, _extends etc

* use NUL convention for helper name

* -> v2.6.0

* -> v2.6.1

* typo

* Merge pull request #73 from zeitiger/updateDocumentationForBabel63

update README for new Babel 6.13

* update dependencies

* Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing

* update build matrix

* update appveyor matrix

* update babel-preset-es2015-rollup for tests

* test with babel-preset-es2015-rollup@3

* Merge pull request #90 from DrewML/update-babel-warning

Remove recommendation to change Babel preset from lib

* Merge pull request #85 from rollup/use-onwarn-if-available

Use options.onwarn if available

* Merge pull request #94 from rtsao/patch-1

Updated external-helpers package name in README

* Merge pull request #99 from AMcBain/master

Ignore Babel 'only' options property for preflight checks.

* Merge pull request #92 from sorgloomer/master

Added externalHelpersWhitelist option

* -> v2.7.0

* Merge pull request #108 from rollup/gh-102

remove ignore from preflight options

* Merge pull request #107 from rollup/gh-105

fix duplicated helper warnings with runtime helpers

* Merge pull request #109 from rollup/gh-95

Allow custom runtime-helpers moduleName

* -> v2.7.1

* -> v2.7.1

* fix prepublish script

* Merge pull request #117 from vinkla/patch-1

Simplify repository config

* make use of object-assign (#118)

Delete assign from utils.js

* Breaking: Babel 7 alpha update (#139)

Breaking: Babel 7 alpha update

* 3.0.0-alpha.12

* update to babel 7 alpha.15

* 3.0.0-alpha.15

* use alpha.17 (#151)

* 3.0.0-alpha.17

* Peer dep (#153)

* make an inline plugin for the preflight check, make babel-core a peerDep

* turn babel-core dep into a peerDep

* fix reference to old class plugin

* update lock file, ignore log files

* 3.0.0

* 3.0.0 changelog [skip ci]

* fix transform (#154)

* 3.0.1

* changelog [skip ci]

* Fix regression with Babel 6 (#158)

* Fix regression with Babel 6

Since in Babel 6 it is not supported to replace the argument
of a default export declaration with an expression, use a
custom "replaceWith" function which handles also that case.

Fixes #155, fixes #156.

* Run tests using both Babel 7 and Babel 6

* 3.0.2

* Fixed support for babel 7 (#170)

* Fixed support for babel 7

* feat(babel): Use scoped babel packages

BREAKING CHANGE: This now requires scoped babel packages to be used.

* Updated to @babel/plugin-proposal-decorators

* Replace es2015 preset with env (#174)

* Merge pull request #150 from wmhilton/patch-1

Use "module" in addition to "jsnext:main"

* 4.0.0-beta.0

* Merge pull request #175 from rollup/existentialism-patch-1

Fix small grammar nit in external-helpers warning

* Update README.md (#163)

Added a missing word and fixed few tiny errors

* Update rollup dependencies and fix tests and build

* merge master -> update-deps

* Merge pull request #147 from kopax/master

clarify README.md showing an example excluding helpers with a variable set to true

* Refactored async tests to bare promises to fix them on older nodes (#194)

* Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (#193)

* 4.0.0-beta.2

* Restore NUL convention for helper name (#198)

The null character `\0` seems to have first been introduced by d169da1.

Fixes #197

* 4.0.0-beta.3

* bumped babel deps

* 4.0.0-beta.4

* Fix npm beta label in README (#207)

Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta".

* Bumped version of babel deps

* Tweaked preflight check (fixes #211)

* 4.0.0-beta.5

* Drop node@4 support

* Bumped all dependencies. (#219)

* Update pinned version of babel.
* Update all development dependencies so this plugin is tested against
  current software.
* Make changes to test needed by updated rollup.
* Add node.js 10 to testing.

* Delegate warnings and errors reporting to rollup (#223)

* Delegate warnings and errors reporting to rollup

* Fixed mocha deprecation warn

* Merge branch 'option-cleanup'

* Cache preflight check results per plugin's instance (#224)

* Merge remote-tracking branch 'miketrexler/modules-false-docs'

* Tweaked babelrc: false workaround recommendation

* Throw when used with module transform BEFORE throwing about unexpected situation (#225)

* Updated deps: eslint, rollup, pluginutils - tests still green

* Fix for issue #220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage.

* Fine-tuned runtime check to allow custom helper name. Issue #220.

* Added new previously failing test for issue #220.

* Made hints related to babel modules:false more explicit and helpful.

* Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting.

* Removed irrelevant babel plugin from a test case

* 4.0.0-beta.6

* Fixed runtime helpers detection with useESModules & useBuiltIns options (#226)

* Add support for esm and builtin runtime helpers

This diff adds support for `useESModules` and `useBuiltIns` options
in transform-runtime plugin which injects paths with `es6` and `builtin`
suffixes.

* Fix lint

* 4.0.0-beta.7

* Improve distributed dist directory (#234)

* Improve dist

- rename .es.js to .esm.js
- removed jsnext:main
- simplified rollup config

* Tweak files and revert external

* Upgrade babel deps and tweak preflight check according to latest changes (#233)

* Upgrade babel and tweak according changes

- simplified preflight check for runtime helpers
- removed moduleName test
- tweaked removed options

* Fix lint

* Regenerate lockfile

* 4.0.0-beta.8

* Transpile only default babel extensions, allow for custom extensions option (fixes #111)

* Pass appropriate caller config to babel.transform (#238)

* 4.0.0

* Update docs regarding babel versions and matching plugin versions

* Bumped babel deps

* 4.0.1

* Fix `rollup` peer dependency (#240)

Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof.

* 4.0.2

* Tweaked README, added 4.0 CHANGELOG notes

* Fixed fallbackClassTransform

* 4.0.3-0

* 4.0.3

* Fix preflightChecks for ignored files

* Setup prettier

* Run prettier over the repo files

* Tweak eslint rules to stop conflicting with prettier output

* 4.1.0-0

* Add options.extensions to README (#256)

* Upgraded husky

* Remove babel 6 test from AppVeyor (#263)

* Remove babel 6 test from appveyor

* Remove reduntant echo

* Fix indentation in examples of configuration in readme (#266)

* Return null from the transform hook when it doesn't transform anything

* 4.1.0-1

* 4.1.0

* Reword 'except' as 'plus' (#280)

* Allow rollup@1 as peer dep

* 4.2.0

* Update devDep to rollup@1

* Fail build when trying plugin tries to add non-existent helper (#290)

* Merge branch 'custom-builder'

* 4.3.0

* Fix reference to the plugin in the README

* Update CHANGELOG

* Add js extention to helper file (#296)

* 4.3.1

* Add note to CHANGELOG about v4.3.1

* Fix usage with externalHelpers flag

* 4.3.2

* Update CHANGELOG with note about 4.3.2

* chore: audit fixes

* chore: npm audit fix

* Update [email protected] (#311)

* Update [email protected]

Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability.

https://nodesecurity.io/advisories/786

* Regenerate package-lock

* 4.3.3

* Add possibility to run babel per output (#333)

* Update dependencies

* First draft for using the plugin to transform output options

* Deduplicate code

* Pass correct context to transformCode

* Update documentation and add chunking test

* Fix Windows tests

* Address review comments

* No longer respect "file" and "dir" options and adjust docs

* Use plugin.generated for output plugin

* Add warning for formats other than ESM or CJS, update docs

* Throw for not recommended formats but add an override option.

* Address review comments

* Fixed issue with incorrect caller data being passed to Babel by generated output plugins

* Reduce information about external helpers as those are not recommended

* Add `sourceType` when transforming the output.

* Update test and readme for runtime helpers

* Add note about babelrc files

* Do not load config files by default

* Update dependencies

* Note minimal Rollup version for output plugins

* Merge branch 'tla'

# Conflicts:
#	src/index.js

* Use babel.transformAsync (#331)

* Use rimraf in prebuild script (#335)

* use rimraf

* move to dev dep

* Drop node 6 support, use untranspiled async/await syntax

* Recommend explicit babelHelpers option to be used (#339)

* Refactored babelHelpers settings - require user declaring which kind of helpers they want to use

* Adjust tests to new babelHelpers logic

* Keep UNRESOLVED_IMPORT warnings out of the console when running tests

* 5.0.0-alpha.0

* Rename skipBabelHelpersCheck to skipPreflightCheck

* Make missing babelHelpers a warning

* 5.0.0-alpha.1

* Use transformAsync in preflight check

* Tweak implementation of the preflight helpers check

* Add example to the README how to use the plugin with the Rollup CLI (#327)

* explain how to configure the rollup cli

* Tweak README

* Dont crash on minified code when performing preflight check

* Rename rollup-plugin-babel directory to babel

* Remove tooling configs not needed in monorepo

* Drop transpilation of rollup-plugin-babel, set engines to node@>=10

* Reformat babel plugin with monorepo prettier & ESLint rules

* Use exports: named for babel plugin CJS bundle

* Migrate babel plugin tests to use ava

* Use pnpm to run npm scripts in babel plugin

* Use scoped @rollup/plugin-json in babel plugin

* Remove unnecessary eslint-disable comment

* Update babel plugin metadata to point to monorepo

* Remove LICENSE file from babel plugin, pnpm will use the root one when publishing

* Move .eslints with turned off rules to fixtures directory

* Move loop counter declaration

* use getCode helper where possible

* Use more proper throwsAsync & notThrowsAsync assertions

* Transpile @rollup/plugin-babel using itself

* Migrate to use @rollup/pluginutils in babel plugin

* Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins

* Fix homepage in babel plugin package.json

* Include repository reference in test descriptionbs refering to issue numbers

* Change URLs in the source files to point to a plugins repo

* Change rollup-plugin-babel to @rollup/plugin-babel in source files

* cleanup README a little bit

* Tweak "Modules" section, remove mentions of Babel 6 from there

* Fix some more references to rollup-plugin-babel

* Add badges to the top of the README

* Adhere to the README template used by other plugins

* Tweak CHANGELOG

* Mention Babel plugin in the root README

* Add publishConfig to package.json of the Babel plugin

* Update packages/babel/README.md

Co-Authored-By: Tiger Oakes <[email protected]>

* Update packages/babel/README.md

Co-Authored-By: Tiger Oakes <[email protected]>

* Fixed how @rollup/pluginutils are used

* Allow Rollup 2 in peer dependency range

* Refactor babel plugin exports shape

* tweak usage example in the babel plugin README

* Align package.json of Babel plugin to existing package.json files in the monorepo

* Update @rollup/pluginutils in the Babel plugin

* Add new changelog entries to the Babel plugin

* Move babelHelpers recommendation text to the README

* Fix typo in the README

* chore: remove prepare script, build in prepublishOnly

This avoids fresh `pnpm install` problems where the build runs
before babel plugins are installed.

* Upgrade @babel/preset-env in babel plugin

Co-authored-by: Rich-Harris <[email protected]>
Co-authored-by: Oskar Segersvärd <[email protected]>
Co-authored-by: Brian Donovan <[email protected]>
Co-authored-by: Yuta Hiroto <[email protected]>
Co-authored-by: Henry Zhu <[email protected]>
Co-authored-by: Nicolò Ribaudo <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: Daniel Tschinder <[email protected]>
Co-authored-by: Brian Ng <[email protected]>
Co-authored-by: Roy Revelt <[email protected]>
Co-authored-by: Minh Nguyen <[email protected]>
Co-authored-by: Can Göktas <[email protected]>
Co-authored-by: Corey Farrell <[email protected]>
Co-authored-by: Sebastian Werner <[email protected]>
Co-authored-by: Bogdan Chadkin <[email protected]>
Co-authored-by: ylemkimon <[email protected]>
Co-authored-by: Kristoffer <[email protected]>
Co-authored-by: Shadab Khan <[email protected]>
Co-authored-by: Adam Gołąb <[email protected]>
Co-authored-by: Kinrany <[email protected]>
Co-authored-by: Mike Heddes <[email protected]>
Co-authored-by: shellscape <[email protected]>
Co-authored-by: Ryan Walters <[email protected]>
Co-authored-by: Lukas Taegert-Atkinson <[email protected]>
Co-authored-by: Troy Rhinehart <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: Tiger Oakes <[email protected]>
@KevinAst
Copy link

KevinAst commented May 13, 2020

I have experienced this exact issue (details here) ... very interested in this resolution!

The severity of this issue will vary based on the application itself:

  1. Certainly in all cases, the bundle size will be bloated (with duplicate definitions).

  2. If the app relies on things like instanceof MyClass, it will be problematic.

  3. In my case, the severity escalates to making it unusable, because my domain object model is somewhat advanced, utilizing package managers that are registering meta information directly on the class definitions ... which cannot be reliably accessed with the duplicate definitions.

The work-around to this issue is to consistently use the same import type (either relative or absolute imports), and the duplicate class definitions disappeared. For now, I chose to stop using the alias rollup plugin.

</Kevin>

@shellscape
Copy link
Collaborator

Hey folks. This issue hasn't received any traction for more than 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

@KevinAst
Copy link

It doesn't seem appropriate to close a "known issue" simply for lack of "traction" :-(

I suspect more people are experiencing this issue without realizing it ... where the only symptom is a bloated bundle size (see my severity comments above).

@shellscape
Copy link
Collaborator

See: https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea

We've now setup the probot to handle this automatically, getting a lot of fatigue from explaining why this is done and folks not understanding how large repos are managed.

Please keep further discussion on topic of the issue details and not repo management.

@masrlinu
Copy link
Author

When will this issue be opened again? It is still closed! This is a very important issue!

@shellscape
Copy link
Collaborator

shellscape commented Jul 10, 2020

if it's very important to you, which we certainly don't minimize, please consider opening a pull request to address it, or rallying support from the community to resolve the issue.

@KevinAst
Copy link

@shellscape ... I did not intend to cast a "disparaging connotation" to you. I very much appreciate your contributions to the OSS community.

My only point was that in this particular case, this issue may deserve extra consideration. I believe this issue to be much broader scoped than the two individuals on this thread.

Developers may be experiencing this issue without realizing it, when the only artifact is a bloated bundle size! Please reread my original comment (above) dealing with severity levels and work-around.

Your help (and consideration) is greatly appreciated :-)

LarsDenBakker pushed a commit to LarsDenBakker/plugins that referenced this issue Sep 12, 2020
* initial commit

* allow include/exclude

* admin and README

* -> 1.0.0

* fix prepublish script

* Update README.md

* make compatible with babel 6

* -> 2.0.0

* Merge pull request rollup#6 from Victorystick/patch-1

Add repository

* Merge pull request rollup#8 from TrySound/tidy-up

Tidy up

* -> 2.0.1

* remove unnecessary logging

* bump up timeout, to try and fix tests on 0.12

* generate sourcemaps by default

* -> 2.1.0

* test for rollup#16

* run preflight check per file – fixes rollup#16

* -> 2.2.0

* Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel

* debug travis test failure

* add missing devDep

* add appveyor config

* es6ify source code

* fix tests on windows?

* install babel-register

* Merge pull request rollup#19 from rollup/rollupgh-17

Better handling of helpers

* -> 2.3.0

* -> 2.3.2

* fix incomprehensible travis test failure

* fix helper renaming (rollup#22)

* -> 2.3.3

* fix failing preflight check in absence of class transformer (closes rollup#23)

* -> 2.3.4

* Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel

* use class transformer local to plugin

* -> 2.3.5

* typo

* verify warnings are correct

* prevent unnecessary `var babelHelpers = {}`

* update rollup

* Merge pull request rollup#29 from rollup/fix-preflight-check-caching

Ensure caching works properly for repeated calls with the same `dir`.

* -> 2.3.6

* remove some debugging code

* Merge pull request rollup#31 from ericf/fix-babel-helper-bindings

Fix Babel helper binding renaming

* -> 2.3.7

* -> 2.3.8

* external-helpers-2 -> external-helpers

* Merge remote-tracking branch 'ericf/remove-babel-helper-renaming'

* -> 2.3.9

* Update README.md

* Merge pull request rollup#41 from joeldenning/external-helpers

Adding support for referencing external, global helpers

* -> 2.4.0

* import helpers, so that transform function is pure

* update test

* update deps, switch from babel to buble

* -> v2.5.0

* install buble

* Merge pull request rollup#57 from rollup/mocha-opts

Extract mocha options into their own file.

* Merge pull request rollup#56 from rollup/rollupgh-55

typeof

* -> v2.5.1

* Update dependencies.

* dont export _typeof, _extends etc

* use NUL convention for helper name

* -> v2.6.0

* -> v2.6.1

* typo

* Merge pull request rollup#73 from zeitiger/updateDocumentationForBabel63

update README for new Babel 6.13

* update dependencies

* Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing

* update build matrix

* update appveyor matrix

* update babel-preset-es2015-rollup for tests

* test with babel-preset-es2015-rollup@3

* Merge pull request rollup#90 from DrewML/update-babel-warning

Remove recommendation to change Babel preset from lib

* Merge pull request rollup#85 from rollup/use-onwarn-if-available

Use options.onwarn if available

* Merge pull request rollup#94 from rtsao/patch-1

Updated external-helpers package name in README

* Merge pull request rollup#99 from AMcBain/master

Ignore Babel 'only' options property for preflight checks.

* Merge pull request rollup#92 from sorgloomer/master

Added externalHelpersWhitelist option

* -> v2.7.0

* Merge pull request rollup#108 from rollup/rollupgh-102

remove ignore from preflight options

* Merge pull request rollup#107 from rollup/rollupgh-105

fix duplicated helper warnings with runtime helpers

* Merge pull request rollup#109 from rollup/rollupgh-95

Allow custom runtime-helpers moduleName

* -> v2.7.1

* -> v2.7.1

* fix prepublish script

* Merge pull request rollup#117 from vinkla/patch-1

Simplify repository config

* make use of object-assign (rollup#118)

Delete assign from utils.js

* Breaking: Babel 7 alpha update (rollup#139)

Breaking: Babel 7 alpha update

* 3.0.0-alpha.12

* update to babel 7 alpha.15

* 3.0.0-alpha.15

* use alpha.17 (rollup#151)

* 3.0.0-alpha.17

* Peer dep (rollup#153)

* make an inline plugin for the preflight check, make babel-core a peerDep

* turn babel-core dep into a peerDep

* fix reference to old class plugin

* update lock file, ignore log files

* 3.0.0

* 3.0.0 changelog [skip ci]

* fix transform (rollup#154)

* 3.0.1

* changelog [skip ci]

* Fix regression with Babel 6 (rollup#158)

* Fix regression with Babel 6

Since in Babel 6 it is not supported to replace the argument
of a default export declaration with an expression, use a
custom "replaceWith" function which handles also that case.

Fixes rollup#155, fixes rollup#156.

* Run tests using both Babel 7 and Babel 6

* 3.0.2

* Fixed support for babel 7 (rollup#170)

* Fixed support for babel 7

* feat(babel): Use scoped babel packages

BREAKING CHANGE: This now requires scoped babel packages to be used.

* Updated to @babel/plugin-proposal-decorators

* Replace es2015 preset with env (rollup#174)

* Merge pull request rollup#150 from wmhilton/patch-1

Use "module" in addition to "jsnext:main"

* 4.0.0-beta.0

* Merge pull request rollup#175 from rollup/existentialism-patch-1

Fix small grammar nit in external-helpers warning

* Update README.md (rollup#163)

Added a missing word and fixed few tiny errors

* Update rollup dependencies and fix tests and build

* merge master -> update-deps

* Merge pull request rollup#147 from kopax/master

clarify README.md showing an example excluding helpers with a variable set to true

* Refactored async tests to bare promises to fix them on older nodes (rollup#194)

* Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (rollup#193)

* 4.0.0-beta.2

* Restore NUL convention for helper name (rollup#198)

The null character `\0` seems to have first been introduced by d169da1.

Fixes rollup#197

* 4.0.0-beta.3

* bumped babel deps

* 4.0.0-beta.4

* Fix npm beta label in README (rollup#207)

Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta".

* Bumped version of babel deps

* Tweaked preflight check (fixes rollup#211)

* 4.0.0-beta.5

* Drop node@4 support

* Bumped all dependencies. (rollup#219)

* Update pinned version of babel.
* Update all development dependencies so this plugin is tested against
  current software.
* Make changes to test needed by updated rollup.
* Add node.js 10 to testing.

* Delegate warnings and errors reporting to rollup (rollup#223)

* Delegate warnings and errors reporting to rollup

* Fixed mocha deprecation warn

* Merge branch 'option-cleanup'

* Cache preflight check results per plugin's instance (rollup#224)

* Merge remote-tracking branch 'miketrexler/modules-false-docs'

* Tweaked babelrc: false workaround recommendation

* Throw when used with module transform BEFORE throwing about unexpected situation (rollup#225)

* Updated deps: eslint, rollup, pluginutils - tests still green

* Fix for issue rollup#220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage.

* Fine-tuned runtime check to allow custom helper name. Issue rollup#220.

* Added new previously failing test for issue rollup#220.

* Made hints related to babel modules:false more explicit and helpful.

* Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting.

* Removed irrelevant babel plugin from a test case

* 4.0.0-beta.6

* Fixed runtime helpers detection with useESModules & useBuiltIns options (rollup#226)

* Add support for esm and builtin runtime helpers

This diff adds support for `useESModules` and `useBuiltIns` options
in transform-runtime plugin which injects paths with `es6` and `builtin`
suffixes.

* Fix lint

* 4.0.0-beta.7

* Improve distributed dist directory (rollup#234)

* Improve dist

- rename .es.js to .esm.js
- removed jsnext:main
- simplified rollup config

* Tweak files and revert external

* Upgrade babel deps and tweak preflight check according to latest changes (rollup#233)

* Upgrade babel and tweak according changes

- simplified preflight check for runtime helpers
- removed moduleName test
- tweaked removed options

* Fix lint

* Regenerate lockfile

* 4.0.0-beta.8

* Transpile only default babel extensions, allow for custom extensions option (fixes rollup#111)

* Pass appropriate caller config to babel.transform (rollup#238)

* 4.0.0

* Update docs regarding babel versions and matching plugin versions

* Bumped babel deps

* 4.0.1

* Fix `rollup` peer dependency (rollup#240)

Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof.

* 4.0.2

* Tweaked README, added 4.0 CHANGELOG notes

* Fixed fallbackClassTransform

* 4.0.3-0

* 4.0.3

* Fix preflightChecks for ignored files

* Setup prettier

* Run prettier over the repo files

* Tweak eslint rules to stop conflicting with prettier output

* 4.1.0-0

* Add options.extensions to README (rollup#256)

* Upgraded husky

* Remove babel 6 test from AppVeyor (rollup#263)

* Remove babel 6 test from appveyor

* Remove reduntant echo

* Fix indentation in examples of configuration in readme (rollup#266)

* Return null from the transform hook when it doesn't transform anything

* 4.1.0-1

* 4.1.0

* Reword 'except' as 'plus' (rollup#280)

* Allow rollup@1 as peer dep

* 4.2.0

* Update devDep to rollup@1

* Fail build when trying plugin tries to add non-existent helper (rollup#290)

* Merge branch 'custom-builder'

* 4.3.0

* Fix reference to the plugin in the README

* Update CHANGELOG

* Add js extention to helper file (rollup#296)

* 4.3.1

* Add note to CHANGELOG about v4.3.1

* Fix usage with externalHelpers flag

* 4.3.2

* Update CHANGELOG with note about 4.3.2

* chore: audit fixes

* chore: npm audit fix

* Update [email protected] (rollup#311)

* Update [email protected]

Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability.

https://nodesecurity.io/advisories/786

* Regenerate package-lock

* 4.3.3

* Add possibility to run babel per output (rollup#333)

* Update dependencies

* First draft for using the plugin to transform output options

* Deduplicate code

* Pass correct context to transformCode

* Update documentation and add chunking test

* Fix Windows tests

* Address review comments

* No longer respect "file" and "dir" options and adjust docs

* Use plugin.generated for output plugin

* Add warning for formats other than ESM or CJS, update docs

* Throw for not recommended formats but add an override option.

* Address review comments

* Fixed issue with incorrect caller data being passed to Babel by generated output plugins

* Reduce information about external helpers as those are not recommended

* Add `sourceType` when transforming the output.

* Update test and readme for runtime helpers

* Add note about babelrc files

* Do not load config files by default

* Update dependencies

* Note minimal Rollup version for output plugins

* Merge branch 'tla'

# Conflicts:
#	src/index.js

* Use babel.transformAsync (rollup#331)

* Use rimraf in prebuild script (rollup#335)

* use rimraf

* move to dev dep

* Drop node 6 support, use untranspiled async/await syntax

* Recommend explicit babelHelpers option to be used (rollup#339)

* Refactored babelHelpers settings - require user declaring which kind of helpers they want to use

* Adjust tests to new babelHelpers logic

* Keep UNRESOLVED_IMPORT warnings out of the console when running tests

* 5.0.0-alpha.0

* Rename skipBabelHelpersCheck to skipPreflightCheck

* Make missing babelHelpers a warning

* 5.0.0-alpha.1

* Use transformAsync in preflight check

* Tweak implementation of the preflight helpers check

* Add example to the README how to use the plugin with the Rollup CLI (rollup#327)

* explain how to configure the rollup cli

* Tweak README

* Dont crash on minified code when performing preflight check

* Rename rollup-plugin-babel directory to babel

* Remove tooling configs not needed in monorepo

* Drop transpilation of rollup-plugin-babel, set engines to node@>=10

* Reformat babel plugin with monorepo prettier & ESLint rules

* Use exports: named for babel plugin CJS bundle

* Migrate babel plugin tests to use ava

* Use pnpm to run npm scripts in babel plugin

* Use scoped @rollup/plugin-json in babel plugin

* Remove unnecessary eslint-disable comment

* Update babel plugin metadata to point to monorepo

* Remove LICENSE file from babel plugin, pnpm will use the root one when publishing

* Move .eslints with turned off rules to fixtures directory

* Move loop counter declaration

* use getCode helper where possible

* Use more proper throwsAsync & notThrowsAsync assertions

* Transpile @rollup/plugin-babel using itself

* Migrate to use @rollup/pluginutils in babel plugin

* Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins

* Fix homepage in babel plugin package.json

* Include repository reference in test descriptionbs refering to issue numbers

* Change URLs in the source files to point to a plugins repo

* Change rollup-plugin-babel to @rollup/plugin-babel in source files

* cleanup README a little bit

* Tweak "Modules" section, remove mentions of Babel 6 from there

* Fix some more references to rollup-plugin-babel

* Add badges to the top of the README

* Adhere to the README template used by other plugins

* Tweak CHANGELOG

* Mention Babel plugin in the root README

* Add publishConfig to package.json of the Babel plugin

* Update packages/babel/README.md

Co-Authored-By: Tiger Oakes <[email protected]>

* Update packages/babel/README.md

Co-Authored-By: Tiger Oakes <[email protected]>

* Fixed how @rollup/pluginutils are used

* Allow Rollup 2 in peer dependency range

* Refactor babel plugin exports shape

* tweak usage example in the babel plugin README

* Align package.json of Babel plugin to existing package.json files in the monorepo

* Update @rollup/pluginutils in the Babel plugin

* Add new changelog entries to the Babel plugin

* Move babelHelpers recommendation text to the README

* Fix typo in the README

* chore: remove prepare script, build in prepublishOnly

This avoids fresh `pnpm install` problems where the build runs
before babel plugins are installed.

* Upgrade @babel/preset-env in babel plugin

Co-authored-by: Rich-Harris <[email protected]>
Co-authored-by: Oskar Segersvärd <[email protected]>
Co-authored-by: Brian Donovan <[email protected]>
Co-authored-by: Yuta Hiroto <[email protected]>
Co-authored-by: Henry Zhu <[email protected]>
Co-authored-by: Nicolò Ribaudo <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: Daniel Tschinder <[email protected]>
Co-authored-by: Brian Ng <[email protected]>
Co-authored-by: Roy Revelt <[email protected]>
Co-authored-by: Minh Nguyen <[email protected]>
Co-authored-by: Can Göktas <[email protected]>
Co-authored-by: Corey Farrell <[email protected]>
Co-authored-by: Sebastian Werner <[email protected]>
Co-authored-by: Bogdan Chadkin <[email protected]>
Co-authored-by: ylemkimon <[email protected]>
Co-authored-by: Kristoffer <[email protected]>
Co-authored-by: Shadab Khan <[email protected]>
Co-authored-by: Adam Gołąb <[email protected]>
Co-authored-by: Kinrany <[email protected]>
Co-authored-by: Mike Heddes <[email protected]>
Co-authored-by: shellscape <[email protected]>
Co-authored-by: Ryan Walters <[email protected]>
Co-authored-by: Lukas Taegert-Atkinson <[email protected]>
Co-authored-by: Troy Rhinehart <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: Tiger Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants