-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): switch to latest celestia node #94
Conversation
WalkthroughThe update involves transitioning the base image in the Dockerfile from an older version ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- Dockerfile (2 hunks)
- entrypoint.sh (1 hunks)
Additional comments: 3
Dockerfile (2)
- 3-3: The update to the base image
ghcr.io/celestiaorg/celestia-node:v0.13.1
aligns with the PR objectives to use the latest Celestia node version. Ensure that this version is compatible with the rest of the project's dependencies and has been tested for any potential security vulnerabilities.- 21-21: The modification of exposed ports to exclude port 26650 and include ports 26657, 26658, 26659, and 9090 should be verified to ensure it aligns with the networking requirements and security best practices of the new Celestia node version. Confirm that these changes do not inadvertently expose the project to security vulnerabilities or disrupt existing network configurations.
entrypoint.sh (1)
- 76-77: The change in command invocation from
celestia-da
tocelestia
for initializing and starting the bridge is in line with the PR objectives to adapt to the new Celestia node version. Ensure that this change has been tested thoroughly to confirm that the bridge initializes and starts as expected without any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Overview
This PR switches celestia-da to latest celestia node v0.13.1
Checklist
Summary by CodeRabbit