Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In this PR I have added comments to the
TransformerInterface
.I also updated the return type on the
TransformerInterface::transform()
method from a union ofnull
andPayload
to just bePayload
. The reason for this is, anull
return type has not been accounted for in the logic flow where the payload is used. It is expected to be aPayload
instance notnull
.I cannot think of a reason to transform the payload to
null
other than to have the error ignored. However, check ignore is the very next step. So, that does not seem like plausible need either.Type of change
Related issues
None
Checklists
Development
Code review