Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed call of method name changed in 8fac418 #583

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

In 8fac418 we renamed the Config properties 'output' and 'output_logger' and to 'log_payload' and 'log_payload_logger' respectively. We also renamed all the exposed methods that operated on these properties. Unfortunately, we missed one call to the old Config::outputLogger() method when doing the refactor. This commit fixes that and adds type annotations and method comments.

Note: at some point after 8fac418 we changed the property syntax from snake case to camel case.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Dec 12, 2022
@danielmorell danielmorell added this to the v4.0.0 milestone Dec 12, 2022
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 342e769 into next/4.0/main Dec 13, 2022
@danielmorell danielmorell deleted the 4.0/fixed-old-rename branch December 13, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants