Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: php 8 language level mitigations, add typehints for tests #569

Merged
merged 3 commits into from
Jul 29, 2022
Merged

feat: php 8 language level mitigations, add typehints for tests #569

merged 3 commits into from
Jul 29, 2022

Conversation

Chris53897
Copy link
Contributor

Description of the change

  • language level mitigations for php 8. Changes are mostly suggestions from PhpStorm IDE.
  • add typehints for /tests/
  • small fix in order of arguments in tests (assertEquals)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell
Copy link
Collaborator

@Chris53897 thank you for the missive amount of work you have put into this! I'm going to need some time to look at this, but I really like what I have seen so far!

@danielmorell danielmorell self-assigned this May 13, 2022
@danielmorell danielmorell self-requested a review May 13, 2022 14:18
@danielmorell danielmorell changed the base branch from master to next/4.0/main July 29, 2022 21:59
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks really good!

@danielmorell danielmorell merged commit 82a5849 into rollbar:next/4.0/main Jul 29, 2022
@Chris53897 Chris53897 deleted the feature/php-8-features branch July 31, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants