Add transformer option #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to specify a transformer in Symfony. Otherwise, the transformer configuration option is not recognized and an error is thrown.
…nfig Add missing transformer config option
bxsx
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Thanks @danielroehrig
I'm approving and merging the PR into master. I will backport it to 1.x/2.x in separate PRs
|
Related issue: rollbar/rollbar-php-symfony-bundle#65 |
This was referenced Nov 2, 2021
bxsx
pushed a commit
that referenced
this pull request
Nov 2, 2021
bxsx
pushed a commit
that referenced
this pull request
Nov 2, 2021
10 tasks
bxsx
added a commit
that referenced
this pull request
Nov 8, 2021
GH-543-backport-2.x: Add missing transformer config option
bxsx
added a commit
that referenced
this pull request
Nov 8, 2021
GH-543-backport-1.x: Add missing transformer config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Simply added the transformer option as it seems to be supported and is missing. We needed it to name a transfomer in Symfony through a yaml file.