Support PHP 8

[janicekt]

Description of the change

adds PHP 8 support and updates the Rollbar-php package to a php8 supported version. Remove PHP 7 support because it is no longer supported in new version Rollbar-php

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Maintenance
• New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

• Fix [SC-]
• Fix Improve documentation in README.md #1

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests
• All tests related to the changed code pass in development

Code review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
• "Ready for review" label attached to the PR and reviewers assigned
• Issue from task tracker has a link to this pull request
• Changes have been reviewed by at least one other engineer

[janicekt]

this fork i have thrown it on my private project and it works fine .. please review, merge and release new version. thx

[art-cg]

Thanks for the PR. I am not sure if it works with symfony 5.0. Hard to tell without Github Actions (maybe you can run your the tests local with composer install --prefer-lowest).

And we need another PR to add more php versions in Travis (merged upfront) https://github.com/rollbar/rollbar-php-symfony-bundle/blob/master/.travis.yml
Or even better GithubActions tests

[art-cg]

@janicekt What do you think about my PR based on this one?

[janicekt]

Thanks for the PR. I am not sure if it works with symfony 5.0. Hard to tell without Github Actions (maybe you can run your the tests local with composer install --prefer-lowest).

And we need another PR to add more php versions in Travis (merged upfront) https://github.com/rollbar/rollbar-php-symfony-bundle/blob/master/.travis.yml Or even better GithubActions tests

in PHP 8.1 with lowest deps are not tests works because there are PHP deprecations in external deps. That's only OK locally with Symfony 5.4 and newer. Its would be nice to have travis

[janicekt]

Thanks for the PR. I am not sure if it works with symfony 5.0. Hard to tell without Github Actions (maybe you can run your the tests local with composer install --prefer-lowest).

And we need another PR to add more php versions in Travis (merged upfront) https://github.com/rollbar/rollbar-php-symfony-bundle/blob/master/.travis.yml Or even better GithubActions tests

thanks for the comment. I add .travis.yml updates in this PR. But I don't think the travis is doing anything.

[art-cg]

Travis is not running on PR right know (but i guess maintainer has more infos about the usage).
Update: PR for GitHub Actions is ready for review #74

[danielmorell]

Hi @janicekt, thank you for your work on this! We have moved development for PHP 8 to the next/5.x/main branch. We are also planning on using GitHub Actions for our CI. We have merged both #73 and #74 into next/5.x/main.

If there is anything you think is important that was not included already, you could merge next/5.x/main into your branch and update this PR.

[janicekt]

on my version I have been working on symfony 5.4 with php8.1 for few months and without any problems .. I'm going to test the migration to 5.0-RC1 version. Thx @danielmorell

[danielmorell]

Today we released the stable v5.0.0. I am going to go ahead and close this PR. @janicekt thank you for your work on this. If, there is anything in here that we are missing in v5, please let's talk about it and figure out a way to move it forward.