Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Exceptions with Throwable, not Exception (PHP 7) #51

Closed
PauliusMacernis opened this issue May 21, 2019 · 0 comments
Closed

Catch Exceptions with Throwable, not Exception (PHP 7) #51

PauliusMacernis opened this issue May 21, 2019 · 0 comments
Assignees
Milestone

Comments

@PauliusMacernis
Copy link

PauliusMacernis commented May 21, 2019

RollbarHandlerFactory should not catch exceptions by using \Exception.
Should most likely be \Throwable
https://github.com/rollbar/rollbar-php-symfony-bundle/blob/master/Factories/RollbarHandlerFactory.php#L48

User data serialization may fail on the FatalError level (as it happened in my case) and this fatal error will not be catch by "Exception". Which will result in reaching maximum function nesting level or a timeout.

Update:
This looks like similar issue:
cakephp/cakephp#9043

@danielmorell danielmorell self-assigned this Jun 20, 2022
@danielmorell danielmorell added this to the v5.0.0 milestone Jul 21, 2022
danielmorell added a commit that referenced this issue Jul 29, 2022
Fixed #51 To make catch statement broader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants